Bug 1861715 - add option for amqp1 SendQueueLimit
Summary: add option for amqp1 SendQueueLimit
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: puppet-collectd
Version: 16.1 (Train)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: z2
: 16.1 (Train on RHEL 8.2)
Assignee: Matthias Runge
QA Contact: Leonid Natapov
URL:
Whiteboard:
Depends On:
Blocks: 1859630 1861716
TreeView+ depends on / blocked
 
Reported: 2020-07-29 11:46 UTC by Matthias Runge
Modified: 2020-10-28 15:39 UTC (History)
9 users (show)

Fixed In Version: puppet-collectd-12.0.0-1.20200626073420.4686e16.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1861716 (view as bug list)
Environment:
Last Closed: 2020-10-28 15:38:39 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github voxpupuli puppet-collectd pull 950 0 None closed Add options to limit the send queue length 2021-02-05 17:19:15 UTC
Red Hat Product Errata RHEA-2020:4284 0 None None None 2020-10-28 15:39:22 UTC

Description Matthias Runge 2020-07-29 11:46:37 UTC 
Description of problem:
https://github.com/collectd/collectd/commit/e7dd149f6f8279d844d172663023a841aa032a93

added the SendQueueLimit option for the amqp1 plugin, which helps with collectd memory usage.

https://github.com/voxpupuli/puppet-collectd/pull/950
adds the support

This bz is to track the option to downstream
Comment 5 Matthias Runge 2020-08-21 07:18:14 UTC 
How to test:
In an environment file add::

ExtraConfig:
    collectd::plugin::amqp1::send_queue_limit: 40

and observe if this parameter SendQueueLimit is added to /etc/collectd.d/10-amqp1.conf

You should also be able to shut off your stf (or stop the route) and you should not see collectd memory usage going up.
Comment 9 Leonid Natapov 2020-10-05 09:47:57 UTC 
# Generated by Puppet
<LoadPlugin amqp1>
  Globals false
  Interval 5
</LoadPlugin>

<Plugin amqp1>
  <Transport "metrics">
    Host "172.17.1.134" 
    Port "5666"
    User "guest"
    Password "guest"
    Address "collectd"
    RetryDelay 1
    SendQueueLimit 40
    <Instance "notify">
      Format "JSON"
      Notify true
      PreSettle false
    </Instance>
    <Instance "telemetry">
      Format "JSON"
      PreSettle false
    </Instance>
  </Transport>
</Plugin>

collectd memory stable after shutting off STF server
Comment 10 Leonid Natapov 2020-10-05 09:51:42 UTC 
# Generated by Puppet
<LoadPlugin amqp1>
  Globals false
  Interval 5
</LoadPlugin>

<Plugin amqp1>
  <Transport "metrics">
    Host "172.17.1.134" 
    Port "5666"
    User "guest"
    Password "guest"
    Address "collectd"
    RetryDelay 1
    SendQueueLimit 40
    <Instance "notify">
      Format "JSON"
      Notify true
      PreSettle false
    </Instance>
    <Instance "telemetry">
      Format "JSON"
      PreSettle false
    </Instance>
  </Transport>
</Plugin>

collectd memory stable after shutting off STF server
Comment 14 errata-xmlrpc 2020-10-28 15:38:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4284
Note You need to log in before you can comment on or make changes to this bug.