Bug 1862621 - Review Request: ocaml-jst-config - Compile-time configuration for Jane Street libraries
Summary: Review Request: ocaml-jst-config - Compile-time configuration for Jane Street...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jared Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1862620
Blocks: 1862628
TreeView+ depends on / blocked
 
Reported: 2020-07-31 20:05 UTC by Jerry James
Modified: 2020-08-17 17:26 UTC (History)
5 users (show)

Fixed In Version: ocaml-jst-config-0.14.0-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-17 17:26:04 UTC
Type: ---
Embargoed:
jsmith.fedora: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2020-07-31 20:05:01 UTC
Spec URL: https://jjames.fedorapeople.org/ocaml-jst-config/ocaml-jst-config.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-jst-config/ocaml-jst-config-0.14.0-1.fc33.src.rpm
Fedora Account System Username: jjames
Description: This package defines compile-time constants used in Jane Street libraries such as Base, Core, and Async.

Comment 1 Jerry James 2020-08-16 02:01:54 UTC
The 'and' has been replaced with 'with' in the BuildRequires, and the build is now verbose.  New URLs:
Spec URL: https://jjames.fedorapeople.org/ocaml-jst-config/ocaml-jst-config.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-jst-config/ocaml-jst-config-0.14.0-1.fc34.src.rpm

Comment 2 Jared Smith 2020-08-16 23:42:44 UTC
Package is approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 8 files have unknown
     license. Detailed output of licensecheck in
     /home/jsmith/Documents/Fedora/Reviews/1862621-ocaml-jst-
     config/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ocaml:
[?]: This should never happen

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ocaml-jst-config-devel-0.14.0-1.fc33.x86_64.rpm
          ocaml-jst-config-0.14.0-1.fc33.src.rpm
ocaml-jst-config-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
ocaml-jst-config-devel.x86_64: W: invalid-url URL: https://github.com/janestreet/jst-config <urlopen error [Errno -3] Temporary failure in name resolution>
ocaml-jst-config-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Source checksums
----------------
https://github.com/janestreet/jst-config/archive/v0.14.0/jst-config-0.14.0.tar.gz :
  CHECKSUM(SHA256) this package     : 729856c893c6f00975140ab158b6c7bf7eea7ea478c3d63556771d61844145dc
  CHECKSUM(SHA256) upstream package : 729856c893c6f00975140ab158b6c7bf7eea7ea478c3d63556771d61844145dc


Requires
--------
ocaml-jst-config-devel (rpmlib, GLIBC filtered):
    ocaml-base-devel(x86-64)
    ocaml-ppx-assert-devel(x86-64)
    ocaml-stdio-devel(x86-64)



Provides
--------
ocaml-jst-config-devel:
    ocaml-jst-config-devel
    ocaml-jst-config-devel(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1862621 -L ./local2
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api, Ocaml
Disabled plugins: Java, fonts, Perl, Python, Haskell, PHP, SugarActivity, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Built with local dependencies:
    /home/jsmith/Documents/Fedora/Reviews/./local2/ocaml-ppx-assert-debuginfo-0.14.0-1.fc33.x86_64.rpm
    /home/jsmith/Documents/Fedora/Reviews/./local2/ocaml-ppx-assert-0.14.0-1.fc33.x86_64.rpm
    /home/jsmith/Documents/Fedora/Reviews/./local2/ocaml-ppx-assert-debugsource-0.14.0-1.fc33.x86_64.rpm
    /home/jsmith/Documents/Fedora/Reviews/./local2/ocaml-ppx-assert-devel-0.14.0-1.fc33.x86_64.rpm

Comment 3 Jerry James 2020-08-17 15:52:08 UTC
Thank you again, Jared!

Comment 4 Gwyn Ciesla 2020-08-17 16:01:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-jst-config

Comment 5 Jerry James 2020-08-17 17:26:04 UTC
Built in F33 and Rawhide.


Note You need to log in before you can comment on or make changes to this bug.