Spec Name or Url: http://david.woodhou.se/bcm43xx-fwcutter.spec SRPM Name or Url: http://david.woodhou.se/bcm43xx-fwcutter-003-1.src.rpm Description: This package contains the 'bcm43xx-fwcutter' tool which is used to extract firmware for the Broadcom network devices, from the official Windows, MacOS or Linux drivers. See the README.Fedora file shipped in the package's documentation for instructions on using this tool.
/usr/bin => %{_bindir}
- $RPM_OPT_FLAGS not honored, fixed eg. by this in %prep: sed -i -e 's/-O2/$(RPM_OPT_FLAGS)/' Makefile - man page not installed - unusual Group tag, suggesting "System Environment/Base" or another suitable one from /usr/share/doc/rpm-*/GROUPS - bogus version in changelog entry - last sentence in README.Fedora ends a bit abruptly, should it have included some info about where to report success or failure?
Thanks for the feedback. Updated spec file and RPM at the same places. Yes, I meant to go create a bug in bugzilla and finish the last sentence in README.Fedora. Bug #186329.
I also added /etc/modprobe.d/bcm43xx.conf to make automatic loading of the module work.
IMO this package is a wrong place to have the modprobe.d snippet in. Once firmwares have been extracted, this package can be removed as it's no longer needed, and that resulting in blowing away the config snippet is very much unexpected. How about just dropping it and documenting bcm43xx related stuff for FC5 in the Wiki? Please bump the release number and add %chnagelog entries every time changes are made, even during package review.
I've changed the modprobe.d snippet to just a %doc file, and referred to it in the README.Fedora file. OK?
Yep, approved.
I see this is already available in devel, but not in FC-5. The FC-5 branch exists in CVS though, so could you push a build for it and close this when done? By the way, 004 is out.
I tried yesterday but the build failed due to infrastructure breakage. Will try again...
Looks better now, thanks.
Please add the package in owners.list