Spec URL: https://decathorpe.fedorapeople.org/packages/jakarta-xml-ws.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/jakarta-xml-ws-2.3.1-1.fc32.src.rpm Description: Jakarta XML Web Services defines a means for implementing XML-Based Web Services based on Jakarta SOAP with Attachments and Jakarta Web Services Metadata. Fedora Account System Username: decathorpe Note: This package was previously named glassfish-jaxws, but was retired for fedora 32+.
I will take this review.
This package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jakarta-xml-ws-2.3.1-1.fc33.noarch.rpm jakarta-xml-ws-javadoc-2.3.1-1.fc33.noarch.rpm jakarta-xml-ws-2.3.1-1.fc33.src.rpm jakarta-xml-ws.noarch: W: no-documentation jakarta-xml-ws-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- jakarta-xml-ws.noarch: W: no-documentation jakarta-xml-ws-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/javaee/jax-ws-spec/archive/2.3.1/jax-ws-spec-2.3.1.tar.gz : CHECKSUM(SHA256) this package : 726d31c12570dff3671b3b85442aa60175917aa6d9edfae661bebb26cf5d8ef9 CHECKSUM(SHA256) upstream package : 726d31c12570dff3671b3b85442aa60175917aa6d9edfae661bebb26cf5d8ef9 Requires -------- jakarta-xml-ws (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(javax.annotation:javax.annotation-api) mvn(javax.xml.bind:jaxb-api) mvn(javax.xml.soap:saaj-api) jakarta-xml-ws-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- jakarta-xml-ws: glassfish-jaxws jakarta-xml-ws mvn(javax.xml.ws:jaxws-api) mvn(javax.xml.ws:jaxws-api:pom:) osgi(javax.xml.ws-api) jakarta-xml-ws-javadoc: glassfish-jaxws-javadoc jakarta-xml-ws-javadoc Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1862680 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: Haskell, Perl, Python, R, Ocaml, SugarActivity, PHP, fonts, C/C++, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review! I have requested the repo and an f33 branch. I wanted to look at some of your pending OCaml package reviews today for Swaps anyway :-) master: https://pagure.io/releng/fedora-scm-requests/issue/27527 f33: https://pagure.io/releng/fedora-scm-requests/issue/27528
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jakarta-xml-ws
Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1592944 and for f33: https://koji.fedoraproject.org/koji/buildinfo?buildID=1592948