Bug 1862722 - Remove unused ImageTransfer.signed_ticket
Summary: Remove unused ImageTransfer.signed_ticket
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.4.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.3
: 4.4.3.3
Assignee: Nir Soffer
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-01 21:04 UTC by Nir Soffer
Modified: 2023-09-14 06:04 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.4.3.3
Clone Of:
Environment:
Last Closed: 2020-10-25 08:31:52 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 108534 0 master MERGED imageio: Remove ImageTransfer.signed_ticket 2020-12-20 08:05:03 UTC
oVirt gerrit 110582 0 master MERGED core: Remove unused ImageTransfer.signed_ticket 2020-12-20 08:05:03 UTC
oVirt gerrit 110916 0 ovirt-engine-4.4.2.z MERGED core: Remove unused ImageTransfer.signed_ticket 2020-12-20 08:05:03 UTC
oVirt gerrit 111373 0 master MERGED Upgrade: model 4.4.18, metamodel 1.3.2 2020-12-20 08:05:03 UTC

Description Nir Soffer 2020-08-01 21:04:40 UTC
Description of problem:

ImageTransfer.signed_ticket is unused since 4.2.0. In oVirt 4.4 engine
does not set this parameter. Trying to use it in the SDK will fail since
the value is always None.

However ovirt-engine-api-model still document this useless value and wrong
usage of the Authorization header which was never used with ovirt-imageio
daemon, and ignored in the proxy since 4.2.0.

The singed ticket was used on the proxy only for engine communication with
the proxy, adding and removing tickets.

Tasks:
- Remove usage of signed_ticket from enigne
- Remove signed_ticket from ovirt-engine-api-model
- Fix the wrong documentation 

Version-Release number of selected component (if applicable):
4.4.2

Not testing is needed except the normal regression tests.

Comment 1 Nir Soffer 2020-08-01 21:07:31 UTC
The attached patch handles ovirt-engine-api-model, but before we
can merge it we need to remove references to this field from
ovirt-engine.

Comment 2 Sandro Bonazzola 2020-08-28 15:22:53 UTC
This bug should move to 4.4.3: the bug is not marked as blocker and despite it was merged in 4.4.2.z branch there is no further planned build for ovirt-engine 4.4.2.

Comment 4 Sandro Bonazzola 2020-11-11 06:45:44 UTC
This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 5 Red Hat Bugzilla 2023-09-14 06:04:41 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.