Bug 1863335 - mirrored installs broken
Summary: mirrored installs broken
Keywords:
Status: CLOSED DUPLICATE of bug 1862979
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Machine Config Operator
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Antonio Murdaca
QA Contact: Michael Nguyen
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-03 15:52 UTC by Colin Walters
Modified: 2021-04-05 17:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-04 09:47:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Colin Walters 2020-08-03 15:52:53 UTC
The extension system PR broke disconnected installs because `oc` is unaware of ICSP.  I'd recommended `oc` because it avoids SELinux issues.

We may need to fall back to `podman mount` and try to hack around SELinux - or alternatively scheduling a pod on the node that serves via HTTP would likely work very well.

Comment 1 Antonio Murdaca 2020-08-03 16:08:45 UTC
Is https://github.com/openshift/enhancements/pull/334 another option to avoid _not_ using oc?

Comment 2 Sinny Kumari 2020-08-04 06:59:44 UTC
(In reply to Colin Walters from comment #0)
> The extension system PR broke disconnected installs because `oc` is unaware
> of ICSP.  I'd recommended `oc` because it avoids SELinux issues.
> 
> We may need to fall back to `podman mount` and try to hack around SELinux -

I see https://bugzilla.redhat.com/show_bug.cgi?id=1863335 is resolved and we have podman-1.9.3-2.rhaos4.6.el8.x86_64 and container-selinux-2.135.0-1.module+el8.2.1+6849+893e4f4a.noarch in OCP 4.6 nightlies.

@Colin do you think this unblocks rpm-ostree selinux issues to perform rebase and install from mounted container in container context?

If not, another option is to revert back existing extensions implementation and fallback to previous implementation where we diverged to use oc image extract https://github.com/openshift/machine-config-operator/pull/1850 and we can do rpm-ostreed.service start/stop dance as mentioned in https://github.com/openshift/machine-config-operator/pull/1850#issuecomment-659472732

Comment 3 Antonio Murdaca 2020-08-04 09:47:31 UTC

*** This bug has been marked as a duplicate of bug 1862979 ***

Comment 4 Sinny Kumari 2020-08-04 10:23:19 UTC
After having a brainstorming session with Antonio today, we came up with another solution to fix the problem and this involves minimal changes:
- We keep the current implementation (i.e keep using oc image extract) of CoreOS extensions support
- Until oc fixes gets in to support mirror registry- when `oc image extract` fails, we fallback to copying machine-os-content on nodes using `podman pull osImageURL && podman create osImageURL && podman cp container_ID:/ /run/machine-os-content/os-content-XXXX`

The fallback solution is applied only when oc image extract has failed.

Comment 5 W. Trevor King 2021-04-05 17:45:59 UTC
Removing UpgradeBlocker from this older bug, to remove it from the suspect queue described in [1].  If you feel like this bug still needs to be a suspect, please add keyword again.

[1]: https://github.com/openshift/enhancements/pull/475


Note You need to log in before you can comment on or make changes to this bug.