sanlock failed to build from source in Fedora rawhide/f33 https://koji.fedoraproject.org/koji/taskinfo?taskID=47965564 For details on the mass rebuild see: https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild Please fix sanlock at your earliest convenience and set the bug's status to ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks, sanlock will be orphaned. Before branching of Fedora 34, sanlock will be retired, if it still fails to build. For more details on the FTBFS policy, please visit: https://fedoraproject.org/wiki/Fails_to_build_from_source
We have a fix here: https://lists.fedorahosted.org/archives/list/sanlock-devel@lists.fedorahosted.org/message/GDR4LSG4YGE7XA6Z2UCJONNHJUJMAAFJ/ David, can you take a look?
Thanks for digging into this. You're right, -fPIE only makes sense for executables. When you install the patch referenced in c#3, can you also remove the .spec bits which disabled LTO? That was in place to work around the problem you're fixing and it didn't actually work because of the slightly convoluted flags handling within the sanlock .spec file. Thanks, Jeff
(In reply to Jeff Law from comment #2) > Thanks for digging into this. You're right, -fPIE only makes sense for > executables. > > When you install the patch referenced in c#3, can you also remove the .spec > bits which disabled LTO? That was in place to work around the problem > you're fixing and it didn't actually work because of the slightly convoluted > flags handling within the sanlock .spec file. Sure I'll handle that. I wonder how -fPIE worked, it was added in 2014.
The builds was fixed in sanlock-3.8.1-6.fc33: https://koji.fedoraproject.org/koji/taskinfo?taskID=48895634 LTO enabled again in sanlock-3.8.1-7.fc33: https://koji.fedoraproject.org/koji/taskinfo?taskID=48896285
There has been at least one successfull build after mass rebuild. sanlock-3.8.1-7.fc33: https://koji.fedoraproject.org/koji/buildinfo?buildID=1586987