Bug 1864092 - root device hints implementation for bare metal is tied too tightly to baremetalhost api
Summary: root device hints implementation for bare metal is tied too tightly to bareme...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.6
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.6.0
Assignee: Doug Hellmann
QA Contact: Lubov
URL:
Whiteboard:
Depends On: 1871653
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-03 17:59 UTC by Doug Hellmann
Modified: 2020-10-27 16:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:22:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift installer pull 4002 0 None closed Bug 1864092: baremetal: copy the implementation of rootdevicehints from baremetal-operator 2021-01-22 01:04:18 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:22:57 UTC

Description Doug Hellmann 2020-08-03 17:59:12 UTC
The install-config interface to support specifying root device hints was implemented by importing the relevant struct directly from the baremetal-operator and BareMetalHost code base. This contravenes the process used by the installer team of duplicating all data structures, so that the installer API can be changed independently of any CRDs it uses.

Comment 4 Lubov 2020-08-26 08:14:30 UTC
Please, suggest how can this BZ be verified
Is it enough to ensure the feature still working?

Comment 5 Doug Hellmann 2020-08-26 17:00:02 UTC
Yes, the fix for this changes the underlying implementation but does not add any new features. So, verifying that the feature continues to work as before should be sufficient.

Comment 6 Lubov 2020-09-24 15:30:41 UTC
verified by https://bugzilla.redhat.com/show_bug.cgi?id=1871653

Comment 7 Doug Hellmann 2020-10-07 15:14:28 UTC
This was a quibble with the implementation details of a new feature, so does not need a release note.

Comment 9 errata-xmlrpc 2020-10-27 16:22:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.