Red Hat Bugzilla – Bug 186458
openobex: openobex-1.1-inc.patch bogus
Last modified: 2007-11-30 17:11:28 EST
A small thing: The included openobex-1.1-inc.patch, IMO, is not necessary as well as the bit in %prep: sed -i -e 's#includedir=@includedir@#includedir=@includedir@/openobex#g' openobex.pc.in Apps using/requiring openobex-devel should #include <openobex/obex.h> not #include <obex.h> (Else, again IMO, *they* are broken and should be patched... not here in openobex).
This could be dealt with in combination with Bug 180935 which would use the same source rpm for openobex and openobex-apps
Bumping severity because the longer this remains the way it currently is, the more time packagers of dependent apps will spend time working around it.
openobex-1.1-inc.patch is necessary, that the include files are installed in /usr/include/openobex and not in /usr/include directly. I can remove # sed -i -e 's#includedir=@includedir@#includedir=@includedir@/openobex#g' BUT, the original openobex packages seems to install the include headers in /usr/include without openobex-1.1-inc.patch.
According to the openobex apidocs: http://openobex.triq.net/apidocs/c34.html#AEN36 apps using the openobex library are supposed to #include <openobex/obex.h> not #include <obex.h> Hence, my argument for the bogosity of needing -I/usr/include/openobex
Well, then they have to change their Makefile.am, because the way it is now, the include files are installed in the wrong place. I will remove the sed line, which corrects the pkgconfig file.
AFAICT, the include files go to the "wrong place" because you use %makeinstall which overrides the Makefile.am value of includedir = @includedir@/openobex I'd suggest using in your %install section: make install DESTDIR=$RPM_BUILD_ROOT instead.
While we're at it, a few other small suggestions... * %{_includedir}/openobex is unowned * since openobex-devel includes a pkg-config file, it should Requires: pkgconfig * You could enable usb support with ./configure option: --enable-usb and BuildRequires: libusb-devel (not sure if there any consequences of doing so, so that's your call).
* %{_includedir}/openobex is unowned good point * since openobex-devel includes a pkg-config file, it should Requires: pkgconfig You can use openobex-devel without pkgconfig. * You could enable usb support with ./configure option: --enable-usb will do
If I would use # make install DESTDIR=$RPM_BUILD_ROOT then the pkgconfig file would include the /usr/include/openobex directory which would have the same effect like: # sed -i -e 's#includedir=@includedir@#includedir=@includedir@/openobex#g'
hmm, no... forget it... comment #9 is wrong :-)