Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1865758

Summary: [DOC] Missing AMI & KMS parameter description in AWS installation documents
Product: OpenShift Container Platform Reporter: Yunfei Jiang <yunjiang>
Component: DocumentationAssignee: James Brigman <jbrigman>
Status: CLOSED DEFERRED QA Contact: Yunfei Jiang <yunjiang>
Severity: medium Docs Contact: Latha S <lmurthy>
Priority: medium    
Version: 4.6CC: aos-bugs, jbrigman, kalexand, lmurthy
Target Milestone: ---Keywords: Reopened
Target Release: 4.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-09 00:58:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yunfei Jiang 2020-08-04 04:44:00 UTC
Document URL: 
https://docs.openshift.com/container-platform/4.5/installing/installing_aws/installing-aws-customizations.html#installation-configuration-parameters_installing-aws-customizations

Section Number and Name: 
Installation configuration parameters - Table 3. Optional AWS parameters


Describe the issue: 
For KMS: 
missing compute.platform.aws.rootVolume.kmsKeyARN and controlPlane.platform.aws.rootVolume.kmsKeyARN config parameters
according to https://issues.redhat.com/browse/CORS-1388 and https://github.com/openshift/installer/pull/3293 , 
custom KMS key is supported by OCP 4.5, but the it is missing in the documents

For AMI:
missing compute.platform.aws.amiID and controlPlane.platform.aws.amiID config parameters
according to https://issues.redhat.com/browse/CORS-1401 and https://github.com/openshift/installer/pull/3308 , 
custom AMI for machine pool is supported by OCP 4.5, but it is missing in the documents


Suggestions for improvement: 
Add KMS and AMI parameter description in `Table 3. Optional AWS parameters`

Additional information:

Comment 1 Yunfei Jiang 2021-04-19 06:34:25 UTC
Hello James, any updates regarding this bug?

Comment 2 James Brigman 2021-04-20 03:46:36 UTC
Yunfei - thank you for asking. I have enough information to generate half the desired information,
I'm working on generating the other half. I expect to provide further update on my Tuesday workday.
This is an urgent BZ for me, it is part of the supportability work our team is doing to help with caseload.

Comment 3 James Brigman 2021-04-22 02:35:35 UTC
Yunfei - Here is the text I plan to update the table with - I request your review please. 


compute.platform.aws.rootVolume.amiID	AMIID is the AMI that should be used to boot
                                        the ec2 instance. If set, the AMI should
                                        belong to the same region as the cluster.	Valid AWS AMI of type <string>.


compute.platform.aws.rootVolume.kmsKeyARN	The KMS key that will be used to encrypt the EBS volume. 
                                                If no key is provided the default KMS key for the 
                                                account will be used. https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetEbsDefaultKmsKeyId.html	             Valid AWS kmsKeyId type <string>.


controlPlane.platform.aws.amiID	         AMIID is the AMI that should be used to boot
                                         the control plane machines. If set, the AMI
                                         should belong to the same region as the cluster.	     Valid AWS AMI of type <string>.


controlPlane.platform.aws.kmsKeyARN	The KMS key that will be used to encrypt the controlPlane.   Valid AWS kmsKeyId type <string>.
                                        If no key is provided the default KMS key for the account
                                        will be used. 
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetEbsDefaultKmsKeyId.html	

PLEASE NOTE: I took this text from the installer, but after reading https://issues.redhat.com/browse/CORS-1401, it appears I should also say that these values can all be different, since that's the reason for CORS-1401.

Comment 4 James Brigman 2021-04-23 19:10:47 UTC
The PR for this change is here:
https://github.com/openshift/openshift-docs/pull/31856
Yunfei, will you PTAL?

Comment 5 Yunfei Jiang 2021-04-25 08:18:53 UTC
Hello James, thanks for you updates, I just added some comments in PR, PTAL, thanks.

Comment 6 James Brigman 2021-08-27 01:10:55 UTC
Hello and Good Morning/Good Day Yunfei!

I let this BZ sit because Matthew Staebler introduced an entirely different way of looking at the issue, however, I did not have a chance to follow up with him before he went on leave for awhile. In that time, the 4.5 release went out of support and bugs for only 4.5 have been closed.

Therefore, I am following up with you to find out if you agree that this BZ should be closed. PTAL, the original PR is at:
https://github.com/openshift/openshift-docs/pull/31856
(You can see matthew's comments in this PR that caused me to pause.)

Thank you so much for your time, I kindly await your answer, sir.

James Brigman
OpenShift Technical Writer.

Comment 7 Yunfei Jiang 2021-08-27 04:22:54 UTC
James, sure, per your comment 6, closing this bug.

Comment 8 Yunfei Jiang 2021-08-27 04:44:25 UTC
James, 

Although the PR is for 4.5 only, this issue may apply to 4.6+, so re-open this bug and setting Target Release to 4.9, you could backport to 4.6-4.8 in PR, WDTY?

Thanks!

Comment 12 James Brigman 2022-03-18 19:46:16 UTC
Hello Yunfei - I checked other OCP docs versions as you suggested and yes, they need update of three missing parameters:

compute.platform.aws.rootVolume.amiID
compute.platform.aws.rootVolume.kmsKeyARN
(controlPlane.platform.aws.amiID  NO: this has been added to the table already)
controlPlane.platform.aws.kmsKeyARN


The table has become "Table 4. Optional AWS parameters"
These are needed for the tables in 4.6, 4.7. 4.8, 4.9 and 4.10.

Do you agree?

Thank you - James Brigman

Comment 13 Yunfei Jiang 2022-03-23 03:41:42 UTC
James, yes, should be applied for 4.6-4.10, thanks.

Comment 15 James Brigman 2023-02-09 13:19:53 UTC
Hello Latha - the SME I was working with on this issue was Matthew Staebler.
Matthew has left the company. 
So I need to locate the SME who replaced him. I will check on this today.
I would prefer to have the result reviewed by whoever replaced Matthew.

Comment 16 Shiftzilla 2023-03-09 00:58:55 UTC
OpenShift has moved to Jira for its defect tracking! This bug can now be found in the OCPBUGS project in Jira.

https://issues.redhat.com/browse/OCPBUGS-8790