Description of problem: Most recent version of rpkg-common (1.60-7.fc32) from updates-testing breaks fedpkg. Building a package with fedpkg --release f32 local fails. Downgrading to rpkg-common (1.60-3.fc32) solves the problem. Version-Release number of selected component (if applicable): 1.60-7.fc32 How reproducible: Update system with updates-testing repository enabled. After update, try to build any rpm package locally using fedpkg Steps to Reproduce: 1. Update rpkg-common to 1.60-7.fc32 2. Run fedpkg --release f32 local to build any package locally. 3. Actual results: fedpkg --release f32 local fails with Could not execute local: join() argument must be str, bytes, or os.PathLike object, not 'NoneType' Expected results: fedpkg builds the package without any issue. Additional info: I am not sure if the issue is caused by rpkg-common or python3-rpkg, as they will always be upgraded simultaneously. Downgrading solves the issue.
Ok, it seems like some people have problems reproducing the issue, so I made an example in a podman container and can reliably reproduce the issue. steps to reproduce: fresh fedora 32 container: $ podman run -it registry.fedoraproject.org/fedora:32-x86_64 # dnf update # dnf install fedpkg wget make # cd home # wget wget https://kojipkgs.fedoraproject.org//packages/fpaste/0.4.0.1/1.fc32/src/fpaste-0.4.0.1-1.fc32.src.rpm # rpm2cpio fpaste-0.4.0.1-1.fc32.src.rpm |cpio -idm # fedpkg --release f32 local This works fine. Now upgrade with updates-testing. # dnf --enablerepo=updates-testing update # fedpkg -v --release f32 local Could not execute local: join() argument must be str, bytes, or os.PathLike object, not 'NoneType' Traceback (most recent call last): File "/usr/bin/fedpkg", line 11, in <module> load_entry_point('fedpkg==1.38', 'console_scripts', 'fedpkg')() File "/usr/lib/python3.8/site-packages/fedpkg/__main__.py", line 87, in main sys.exit(client.args.command()) File "/usr/lib/python3.8/site-packages/pyrpkg/cli.py", line 2164, in local self.sources() File "/usr/lib/python3.8/site-packages/pyrpkg/cli.py", line 2598, in sources self.cmd.sources(outdir) File "/usr/lib/python3.8/site-packages/pyrpkg/__init__.py", line 2075, in sources if not os.path.exists(self.sources_filename): File "/usr/lib/python3.8/site-packages/pyrpkg/__init__.py", line 1099, in sources_filename return os.path.join(self.path, self.layout.sources_file_template) File "/usr/lib64/python3.8/posixpath.py", line 90, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib64/python3.8/genericpath.py", line 152, in _check_arg_types raise TypeError(f'{funcname}() argument must be str, bytes, or ' TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'
Suggested solution: https://pagure.io/rpkg/pull-request/512#
workaround: in the directory containing 'specfile' execute `touch sources` before running `fedpkg local`.
Thanks, the workaround works like a charm! Of course, I am looking forward to have it fixed in rpkg, as it seems like the sources file is not needed at all. But for the time being the workaround is very helpful.
FEDORA-2020-689d384c29 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-689d384c29
FEDORA-2020-9243b572ea has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9243b572ea
FEDORA-2020-081db3a145 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-081db3a145
FEDORA-EPEL-2020-52b7fffaf0 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-52b7fffaf0
FEDORA-EPEL-2020-b0b739248c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b0b739248c
FEDORA-2020-081db3a145 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-081db3a145` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-081db3a145 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-689d384c29 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-689d384c29` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-689d384c29 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2020-52b7fffaf0 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-52b7fffaf0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2020-b0b739248c has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b0b739248c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-9243b572ea has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-9243b572ea` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9243b572ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
The update fixed the problem for me on Fedora 32. Bug can be closed as fixed, but I am not sure which value is appropriate. So I leave it to someone else to mark as closed and to choose the correct reason.
FEDORA-2020-1d768cb488 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1d768cb488
FEDORA-2020-1d768cb488 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-1d768cb488` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1d768cb488 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-689d384c29 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2020-3b36e3cee4 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-3b36e3cee4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2020-d4790c9c7f has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-d4790c9c7f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-1d768cb488 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2020-3b36e3cee4 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2020-d4790c9c7f has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.