Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1867499

Summary: server version show "dirty"
Product: OpenShift Container Platform Reporter: RamaKasturi <knarra>
Component: ReleaseAssignee: Luke Meyer <lmeyer>
Status: CLOSED ERRATA QA Contact: RamaKasturi <knarra>
Severity: medium Docs Contact:
Priority: high    
Version: 4.6CC: aos-bugs, jdelft, jokerman, mfojtik, sttts, xxia, yinzhou
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:26:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description RamaKasturi 2020-08-10 08:01:56 UTC
server version show "dirty" when use `oc version -o yaml`

Version-Release number of selected component (if applicable):
[ramakasturinarra@dhcp35-60 ~]$ oc version
Client Version: 4.6.0-202008031851.p0-a695d74
Server Version: 4.6.0-0.nightly-2020-08-07-202945
Kubernetes Version: v1.19.0-rc.2+5241b27-dirty

How Reproducible:
Always

Steps to Reproduce:
1) Install latest atomic-openshift-clients from the repo
2) Run oc version -o yaml
[ramakasturinarra@dhcp35-60 ~]$ oc version -o yaml
clientVersion:
  buildDate: "2020-08-03T19:18:12Z"
  compiler: gc
  gitCommit: a695d74ef1aee9a3f605d38dd8b6fae2062b63fc
  gitTreeState: clean
  gitVersion: 4.6.0-202008031851.p0-a695d74
  goVersion: go1.13.4
  major: ""
  minor: ""
  platform: linux/amd64
openshiftVersion: 4.6.0-0.nightly-2020-08-07-202945
serverVersion:
  buildDate: "2020-08-06T08:12:07Z"
  compiler: gc
  gitCommit: 5241b27b8acd73cdc99a0cac281645189189f1d8
  gitTreeState: dirty
  gitVersion: v1.19.0-rc.2+5241b27-dirty
  goVersion: go1.14.4
  major: "1"
  minor: 19+
  platform: linux/amd64
3) Now go to page https://openshift-release-artifacts.svc.ci.openshift.org/4.6.0-0.nightly-2020-08-07-202945/
4) Download https://openshift-release-artifacts.svc.ci.openshift.org/4.6.0-0.nightly-2020-08-07-202945/openshift-client-linux-4.6.0-0.nightly-2020-08-07-202945.tar.gz and extract oc
5) Run the command oc version -o yaml
[ramakasturinarra@dhcp35-60 openshift-client-linux-4.6.0-0.nightly-2020-08-07-202945]$ ./oc version
Client Version: 4.6.0-0.nightly-2020-08-07-202945
Server Version: 4.6.0-0.nightly-2020-08-07-202945
Kubernetes Version: v1.19.0-rc.2+5241b27-dirty
[ramakasturinarra@dhcp35-60 openshift-client-linux-4.6.0-0.nightly-2020-08-07-202945]$ ./oc version -o yaml
clientVersion:
  buildDate: "2020-08-06T20:59:20Z"
  compiler: gc
  gitCommit: a695d74ef1aee9a3f605d38dd8b6fae2062b63fc
  gitTreeState: clean
  gitVersion: openshift-clients-4.6.0-202006250705.p0-69-ga695d74ef
  goVersion: go1.14.4
  major: ""
  minor: ""
  platform: linux/amd64
openshiftVersion: 4.6.0-0.nightly-2020-08-07-202945
releaseClientVersion: 4.6.0-0.nightly-2020-08-07-202945
serverVersion:
  buildDate: "2020-08-06T08:12:07Z"
  compiler: gc
  gitCommit: 5241b27b8acd73cdc99a0cac281645189189f1d8
  gitTreeState: dirty
  gitVersion: v1.19.0-rc.2+5241b27-dirty
  goVersion: go1.14.4
  major: "1"
  minor: 19+
  platform: linux/amd64
  
 Actual Results:
 show dirty
 
 Expected Results:
should not show "dirty"

Comment 1 Joep van Delft 2020-08-17 10:05:29 UTC
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1806825
This is about the server version, rather than the client version.

Comment 2 Luke Meyer 2020-08-21 20:24:40 UTC
Passing this to apiserver because I'm guessing its build needs to determine clean/dirty differently.

http://pkgs.devel.redhat.com/cgit/containers/openshift-enterprise-hyperkube/tree/Dockerfile?h=rhaos-4.6-rhel-7 indicates:
OS_GIT_TREE_STATE=clean SOURCE_GIT_TREE_STATE=clean

Pass it back if ART builds need to supply a KUBE_* var or something (how would we determine that?)

Comment 3 Maru Newby 2020-09-02 02:49:55 UTC
ART will need to supply `KUBE_GIT_TREE_STATE=clean` to ensure the upstream build tooling is correctly configured.

Comment 10 RamaKasturi 2020-09-04 12:51:37 UTC
Verified with the payload below and i do not see server version to be shown dirty anymore.

[ramakasturinarra@dhcp35-60 openshift-client-linux-4.6.0-0.nightly-2020-09-03-191144]$ oc version -o yaml
clientVersion:
  buildDate: "2020-09-04T02:26:55Z"
  compiler: gc
  gitCommit: ae6fae6fa14dbd9625cc6369e79558b58c716254
  gitTreeState: clean
  gitVersion: 4.6.0-202009040156.p0-ae6fae6
  goVersion: go1.14.4
  major: ""
  minor: ""
  platform: linux/amd64
openshiftVersion: 4.6.0-0.nightly-2020-09-04-064335
serverVersion:
  buildDate: "2020-09-04T01:56:40Z"
  compiler: gc
  gitCommit: 068702de7d48739e835ea41b7ca959b5252de432
  gitTreeState: clean
  gitVersion: v1.19.0-rc.2+068702d
  goVersion: go1.14.4
  major: "1"
  minor: 19+
  platform: linux/amd64

[ramakasturinarra@dhcp35-60 openshift-client-linux-4.6.0-0.nightly-2020-09-03-191144]$ oc version
Client Version: 4.6.0-202009040156.p0-ae6fae6
Server Version: 4.6.0-0.nightly-2020-09-04-064335
Kubernetes Version: v1.19.0-rc.2+068702d

Based on the above moving the bug to verified state.

Comment 11 Ke Wang 2020-09-07 07:24:56 UTC
*** Bug 1862042 has been marked as a duplicate of this bug. ***

Comment 13 errata-xmlrpc 2020-10-27 16:26:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196