Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1867529

Summary:	[sriov] mellanox-plugin resets unsupported NICs upon start
Product:	OpenShift Container Platform	Reporter:	zenghui.shi <zshi>
Component:	Networking	Assignee:	zenghui.shi <zshi>
Networking sub component:	SR-IOV	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	bbennett
Version:	4.6
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:26:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zenghui.shi 2020-08-10 09:53:04 UTC

Description of problem:

By default, mellanox plugin sets total VFs to 0 for mellanox interfaces with no spec (user specified). however, this is only applied to unsupported NICs instead of supported NICs due to a wrong conditional check.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. deploy sriov operator in a cluster which contains unsupported Mellanox NICs.
for the list of supported NICs, refers to openshift official document: https://docs.openshift.com/container-platform/4.5/networking/hardware_networks/about-sriov.html#supported-devices_about-sriov
2.
3.

Actual results:
mellanox plugin tries to set total VFs to 0 for unsupported NICs even it's not configured.

Expected results:
mellanox plugin doesn't touch unsupported NICs, if not explicitly configured.

Additional info:

Comment 3 zhaozhanqi 2020-08-25 08:49:37 UTC

Verified this bug on 4.6.0-202008240540.p0

1. Create one policy and delete it. 
2. ssh into config daemon pod
3. Check the num_of_vfs changed to 0.
 sh-4.2# mstconfig -d 5e:00.0 q | grep -i num_of_vfs
         NUM_OF_VFS                          0

Comment 5 errata-xmlrpc 2020-10-27 16:26:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196