Bug 1867529 - [sriov] mellanox-plugin resets unsupported NICs upon start
Summary: [sriov] mellanox-plugin resets unsupported NICs upon start
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.6.0
Assignee: zenghui.shi
QA Contact: zhaozhanqi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-10 09:53 UTC by zenghui.shi
Modified: 2020-10-27 16:26 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-27 16:26:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift sriov-network-operator pull 323 0 None closed BUG 1867529: mellanox plugin - fix resetting unsupported NICs 2020-08-26 03:03:44 UTC
Red Hat Product Errata RHBA-2020:4196 0 None None None 2020-10-27 16:26:48 UTC

Description zenghui.shi 2020-08-10 09:53:04 UTC
Description of problem:

By default, mellanox plugin sets total VFs to 0 for mellanox interfaces with no spec (user specified). however, this is only applied to unsupported NICs instead of supported NICs due to a wrong conditional check.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. deploy sriov operator in a cluster which contains unsupported Mellanox NICs.
for the list of supported NICs, refers to openshift official document: https://docs.openshift.com/container-platform/4.5/networking/hardware_networks/about-sriov.html#supported-devices_about-sriov
2.
3.

Actual results:
mellanox plugin tries to set total VFs to 0 for unsupported NICs even it's not configured.

Expected results:
mellanox plugin doesn't touch unsupported NICs, if not explicitly configured.

Additional info:

Comment 3 zhaozhanqi 2020-08-25 08:49:37 UTC
Verified this bug on 4.6.0-202008240540.p0

1. Create one policy and delete it. 
2. ssh into config daemon pod
3. Check the num_of_vfs changed to 0.
 sh-4.2# mstconfig -d 5e:00.0 q | grep -i num_of_vfs
         NUM_OF_VFS                          0

Comment 5 errata-xmlrpc 2020-10-27 16:26:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196


Note You need to log in before you can comment on or make changes to this bug.