Fedora Account System
Red Hat Associate
Red Hat Customer
Description: Slingshot is a two dimensional, turn based simulation-strategy game set in the gravity fields of several planets. It is a highly addictive game, and never the same from round to round due to its randomly generated playing fields. SRPM: https://fedorapeople.org/~limb/review/slingshot/slingshot-0.9-12.fc33.src.rpm SPEC: https://fedorapeople.org/~limb/review/slingshot/slingshot.spec Re-review, retired due to python 2 requirements, now migrated to python 3.
> Source1: slingshot.desktop > Source2: slingshot.appdata.xml > Patch0: 243aef95dde390f97f1e0abbbdb646b3e5b97f7d.patch Could you add a comment above the "Patch0" field explaining why it's needed? > BuildArchitectures: noarch > BuildRequires: desktop-file-utils, python3-setuptools, python3-devel, libappstream-glib > Requires: hicolor-icon-theme, python3-pygame, gnu-free-sans-fonts - I think the correct name of the field is "BuildArch", but somehow the package builds in mock without issues. - Can you list the BuildRequires and Requires on separate lines and sort them alphabetically? > %files > %{_bindir}/slingshot > %{python3_sitelib}/* The last line is not allowed according to the Python Packaging Guidelines. It's okay to do the following, however: %{python3_sitelib}/%{srcname}-*.egg-info/ %{python3_sitelib}/%{srcname}/ Full review matrix: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/slingshot See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages Review: it's a noarch package. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License", "Unknown or generated", "GPL (v2 or later)". 26 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/slingshot/slingshot/licensecheck.txt Review: the license is GPLv2+ as used in the SPEC file. licensecheck wrongly marks the LICENSE file as LGPL. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. Review: it's a noarch package. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines Review: see earlier comments about %{python3_sitelib} [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python Review: see earlier comment about %{python3_sitelib} [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files Review: font file found at usr/lib/python3.9/site-packages/slingshot/data/FreeSansBold.ttf Can the package use external fonts? [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Review: see earlier comment. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Review: it's a noarch package. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: slingshot-0.9-12.fc33.noarch.rpm slingshot-0.9-12.fc33.src.rpm slingshot.noarch: W: no-manual-page-for-binary slingshot 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name slingshot 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/ryanakca/slingshot/archive/0.9/slingshot-0.9.tar.gz : CHECKSUM(SHA256) this package : 13d950b1ae4650c9710aeba85b59b05cdd5c697b698b04eb0d0be3f7f662a6aa CHECKSUM(SHA256) upstream package : 13d950b1ae4650c9710aeba85b59b05cdd5c697b698b04eb0d0be3f7f662a6aa Requires -------- slingshot (rpmlib, GLIBC filtered): /usr/bin/python3 gnu-free-sans-fonts hicolor-icon-theme python(abi) python3-pygame Provides -------- slingshot: application() application(slingshot.desktop) metainfo() metainfo(slingshot.appdata.xml) python3.9dist(slingshot) python3dist(slingshot) slingshot
Updated addressing everything above, same URLs.
The font file still ends up at this location: /usr/lib/python3.9/site-packages/slingshot/data/FreeSansBold.ttf I think this line: rm -f slingshot/data/FreeSansBold.ttf should be changed to this and moved to the %prep phase: %prep %setup -q %patch0 -p1 rm -f src/slingshot/data/FreeSansBold.ttf %build %py3_build Tested it locally and it works. Here's the Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49049591 The only problem is that the paths to this font file seem to be hard-coded and the moment I remove it, this happens: pygame 1.9.6 Hello from the pygame community. https://www.pygame.org/contribute.html Traceback (most recent call last): File "/usr/bin/slingshot", line 58, in <module> class Game: File "/usr/bin/slingshot", line 64, in Game Settings.font = pygame.font.Font(get_data_path("FreeSansBold.ttf"), 14) FileNotFoundError: [Errno 2] No such file or directory: '/usr/lib/python3.8/site-packages/slingshot/data/FreeSansBold.ttf' The sources seem to confirm it: https://github.com/ryanakca/slingshot/blob/fe976c8c51634b593c14e0a535a6552a0be156cd/src/slingshot/settings.py#L74 Not sure whether even patching this out would do the trick. One would probably need to discuss this with upstream. Do you happen to know how this font file is licensed?
I assume it's GPLv3+ link the rest of the gnu-free-fonts fonts. I've updated the spec/srpm to reflect moving the rm -f statement, and symlinking to the required font file. It works.
Nice, package approved!
Thank you!
FEDORA-2020-7782c87781 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7782c87781
FEDORA-2020-7782c87781 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7782c87781` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7782c87781 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-7782c87781 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.