Bug 1868902 - LegacyLogObserverWrapper python3.8 compatibility
Summary: LegacyLogObserverWrapper python3.8 compatibility
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: deluge
Version: 32
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Michael Cronenworth
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-14 08:14 UTC by Kapetanakis Giannis
Modified: 2020-08-26 14:51 UTC (History)
3 users (show)

Fixed In Version: deluge-2.0.3-11.fc32
Clone Of:
Environment:
Last Closed: 2020-08-26 14:51:36 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Kapetanakis Giannis 2020-08-14 08:14:22 UTC
I believe this patch needs to be included:
https://git.deluge-torrent.org/deluge/commit/?h=develop&id=351664ec071daa04161577c6a1c949ed0f2c3206

without this I get tons of spam logging

Unhandled error in Deferred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/deluge/common.py", line 1344, in run_profiled
    return func(*args)
  File "/usr/lib/python3.8/site-packages/deluge/core/daemon_entry.py", line 137, in run_daemon
    log.info('Exiting...')
  File "/usr/lib64/python3.8/site-packages/twisted/internet/defer.py", line 1613, in unwindGenerator
    return _cancellableInlineCallbacks(gen)
  File "/usr/lib64/python3.8/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
    _inlineCallbacks(None, g, status)
--- <exception caught here> ---
  File "/usr/lib64/python3.8/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/usr/lib/python3.8/site-packages/deluge/log.py", line 69, in info
    yield LoggingLoggerClass.info(self, msg, *args, **kwargs)
  File "/usr/lib64/python3.8/logging/__init__.py", line 1434, in info
    self._log(INFO, msg, args, **kwargs)
  File "/usr/lib64/python3.8/logging/__init__.py", line 1565, in _log
    fn, lno, func, sinfo = self.findCaller(stack_info, stacklevel)
builtins.TypeError: findCaller() takes from 1 to 2 positional arguments but 3 were given

Temporarily disabling observer LegacyLogObserverWrapper(<bound method TwistedLoggingObserver.emit of <deluge.log.TwistedLoggingObserver object at 0x7f9aea2c23a0>>) due to exception: [Failure instance: Traceback: <class 'TypeError'>: findCaller() takes from 1 to 2 positional arguments but 3 were given
/usr/lib64/python3.8/site-packages/twisted/internet/defer.py:962:__del__
/usr/lib64/python3.8/site-packages/twisted/logger/_logger.py:190:failure
/usr/lib64/python3.8/site-packages/twisted/logger/_logger.py:144:emit
--- <exception caught here> ---
/usr/lib64/python3.8/site-packages/twisted/logger/_observer.py:131:__call__
/usr/lib64/python3.8/site-packages/twisted/logger/_legacy.py:93:__call__
/usr/lib/python3.8/site-packages/deluge/log.py:204:emit
/usr/lib64/python3.8/logging/__init__.py:1481:critical
/usr/lib64/python3.8/logging/__init__.py:1565:_log
]
Traceback (most recent call last):
  File "/usr/lib64/python3.8/site-packages/twisted/internet/defer.py", line 962, in __del__
    log.failure(format,
  File "/usr/lib64/python3.8/site-packages/twisted/logger/_logger.py", line 190, in failure
    self.emit(level, format, log_failure=failure, **kwargs)
  File "/usr/lib64/python3.8/site-packages/twisted/logger/_logger.py", line 144, in emit
    self.observer(event)
--- <exception caught here> ---
  File "/usr/lib64/python3.8/site-packages/twisted/logger/_observer.py", line 131, in __call__
    observer(event)
  File "/usr/lib64/python3.8/site-packages/twisted/logger/_legacy.py", line 93, in __call__
    self.legacyObserver(event)
  File "/usr/lib/python3.8/site-packages/deluge/log.py", line 204, in emit
    getattr(LoggingLoggerClass, event_dict['log_level'].name)(
  File "/usr/lib64/python3.8/logging/__init__.py", line 1481, in critical
    self._log(CRITICAL, msg, args, **kwargs)
  File "/usr/lib64/python3.8/logging/__init__.py", line 1565, in _log
    fn, lno, func, sinfo = self.findCaller(stack_info, stacklevel)
builtins.TypeError: findCaller() takes from 1 to 2 positional arguments but 3 were given

Comment 1 Fedora Update System 2020-08-18 21:28:44 UTC
FEDORA-2020-18d49ead48 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-18d49ead48

Comment 2 Fedora Update System 2020-08-19 01:12:07 UTC
FEDORA-2020-18d49ead48 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-18d49ead48`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-18d49ead48

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Kapetanakis Giannis 2020-08-26 07:17:34 UTC
Works fine for me.  

I don't have an account in bodhi to post there as well.

Comment 4 Fedora Update System 2020-08-26 14:51:36 UTC
FEDORA-2020-18d49ead48 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.