Bug 1869128 - Review Request: ilopona - toki pona dictionary
Summary: Review Request: ilopona - toki pona dictionary
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bob Hepple
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2020-08-17 02:53 UTC by Janet Blackquill
Modified: 2024-02-12 04:25 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-09-17 00:45:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Janet Blackquill 2020-08-17 02:53:06 UTC
Spec URL: https://appadeia.fedorapeople.org/packaging/ilopona/ilopona.spec
SRPM URL: https://appadeia.fedorapeople.org/packaging/ilopona/ilopona-1.0.0-1.fc32.src.rpm
Description: ilo pona is a simple dictionary application for toki pona.
Fedora Account System Username: appadeia

Comment 1 Bob Hepple 2020-08-17 07:12:14 UTC
*** The online help->License indicates "The writing in the background of the word definitions is licensed under CC BY-NC-SA 4.0." I think this should be mentioned in License: and %license

*** Please remove '.' from the end of the Summary: line

*** Please use desktop-file-install: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.

eg something like:
BuildRequires: desktop-file-utils
...
desktop-file-install \
        --dir %{buildroot}%{_datadir}/applications              \
        --remove-category Application                           \
        %{name}.desktop

... --add-category/--remove-category as appropriate for ilopona - see 'man desktop-file-install'


*** Please validate appdata.xml file
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData: The AppData files MUST correctly validate using appstream-util validate-relax
eg. something like this:

BuildRequires: libappstream-glib
...
%check (or %install)
appstream-util validate-relax --nonet %{_metainfodir}/*.appdata.xml

... note the use of %{_metainfodir} (which can also be used in %files)

*** Minor bugaboos: optional:

$ rpmlint /home/bhepple/rpmbuild/RPMS/x86_64/ilopona-1.0.0-1.fc31.x86_64.rpm
ilopona.x86_64: W: description-shorter-than-summary
ilopona.x86_64: W: no-documentation
ilopona.x86_64: W: no-manual-page-for-binary com.github.Appadeia.ilopona

Comment 2 Bob Hepple 2020-08-17 07:24:19 UTC
I would suggest 'Education' as an additional category in .desktop

BTW - it works fine on Fedora-31.

Comment 3 Neal Gompa 2020-08-17 10:28:41 UTC
CC BY-NC-SA is not permitted in Fedora: https://fedoraproject.org/wiki/Licensing:Main#Bad_Licenses_3

Comment 4 Bob Hepple 2020-08-17 22:47:43 UTC
So we're off to RPMFusion then, Carson. Not to worry, your existing FAS credentials are good to go, the process is very similar to Fedora.

Here are some notes:

https://rpmfusion.org/Contributors

Once approved and the git repo is setup, getting a new package prepared is similar to fedora but there is no bodhi: eg
rfpkg clone free/ilopona
rfpkg import ~/rpmbuild/SRPMS/ilopona-1.0.0-2.fc32.src.rpm
rfpkg ci -c
rfpkg push
rfpkg build

and branches:
rfpkg switch-branch f31
git merge master
rfpkg push
rfpkg build
... then close bugzilla

... just send me the bugzilla link when you're ready and I'll review it.

Comment 5 Neal Gompa 2020-08-18 00:23:00 UTC
Carson here is the author of the application being reviewed here. He probably can change the license of the assets to CC-BY-SA (no NC). Would you please consider changing the license?

Comment 6 Package Review 2020-09-17 00:45:17 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 7 rojiho4305@dixiser.com 2023-10-14 05:15:26 UTC Comment hidden (spam)
Comment 8 Red Hat Bugzilla 2024-02-12 04:25:06 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days


Note You need to log in before you can comment on or make changes to this bug.