Spec URL: https://fedorapeople.org/~airlied/spirv-llvm-translator/spirv-llvm-translator.spec SRPM URL: https://fedorapeople.org/~airlied/spirv-llvm-translator/spirv-llvm-translator-10.0.0-1.fc33.src.rpm Description: LLVM to SPIRV IR translator Fedora Account System Username: airlied
- In order to avoid unannounced soname bump, we recommend not globbing the major soname version: %{_libdir}/libLLVMSPIRVLib.so.* - Build fails: CMake Error at CMakeLists.txt:34 (find_package): Could not find a configuration file for package "LLVM" that is compatible with requested version "10.0.0". The following configuration files were considered but not accepted: /usr/lib64/cmake/llvm/LLVMConfig.cmake, version: 11.0.0 /lib64/cmake/llvm/LLVMConfig.cmake, version: 11.0.0 BuildRequires: llvm-devel → BuildRequires: llvm10-devel and %build %cmake -GNinja \ -DLLVM_BUILD_TOOLS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_INSTALL_RPATH:BOOL=";" \ -DCMAKE_PREFIX_PATH=%{_libdir}/llvm10 But then it fails with: CMake Error at /usr/lib64/llvm10/lib/cmake/llvm/LLVMStaticExports.cmake:1122 (message): The imported target "LLVMDemangle" references the file "/usr/lib64/llvm10/lib/libLLVMDemangle.a" but this file does not exist. Possible reasons include: * The file was deleted, renamed, or moved to another location. * An install or uninstall procedure did not complete successfully. * The installation package was faulty and contained "/usr/lib64/llvm10/lib/cmake/llvm/LLVMStaticExports.cmake" but not all the files it references. Call Stack (most recent call first): /usr/lib64/llvm10/lib/cmake/llvm/LLVMConfig.cmake:260 (include) CMakeLists.txt:34 (find_package) -- Configuring incomplete, errors occurred!
Ok so, add: BuildRequires: llvm10-devel BuildRequires: llvm10-static Then: %build export LLVM_DIR=%{_libdir}/llvm10/lib/cmake/ Then it builds But fail because it's installing to /usr/lib instead of %{_libdir} -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-10.0.0-1.fc34.x86_64/usr/lib/pkgconfig/LLVMSPIRVLib.pc -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-10.0.0-1.fc34.x86_64/usr/lib/libLLVMSPIRVLib.so.10 Let's fix it in the %cmake invocation: %cmake -GNinja \ -DLLVM_BUILD_TOOLS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_INSTALL_RPATH:BOOL=";" \ %if "lib64" == "lib64" -DLLVM_LIBDIR_SUFFIX=64 \ %endif Assuming you will fix the package like described above, the package is approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "[generated file]", "Khronos License". 488 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/spirv-llvm- translator/review-spirv-llvm-translator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in spirv- llvm-translator-devel , spirv-llvm-translator-tools [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: spirv-llvm-translator-10.0.0-1.fc34.x86_64.rpm spirv-llvm-translator-devel-10.0.0-1.fc34.x86_64.rpm spirv-llvm-translator-tools-10.0.0-1.fc34.x86_64.rpm spirv-llvm-translator-debuginfo-10.0.0-1.fc34.x86_64.rpm spirv-llvm-translator-debugsource-10.0.0-1.fc34.x86_64.rpm spirv-llvm-translator-10.0.0-1.fc34.src.rpm spirv-llvm-translator.x86_64: W: spelling-error %description -l en_US Khronos -> Kimonos spirv-llvm-translator.x86_64: W: spelling-error %description -l en_US libclc -> libel spirv-llvm-translator-devel.x86_64: W: no-documentation spirv-llvm-translator-tools.x86_64: W: no-documentation spirv-llvm-translator-tools.x86_64: W: no-manual-page-for-binary llvm-spirv spirv-llvm-translator.src: W: spelling-error %description -l en_US Khronos -> Kimonos spirv-llvm-translator.src: W: spelling-error %description -l en_US libclc -> libel 6 packages and 0 specfiles checked; 0 errors, 7 warnings.
Don't forget this too: - In order to avoid unannounced soname bump, we recommend not globbing the major soname version: %{_libdir}/libLLVMSPIRVLib.so.10*
Okay this package has to build against the distro current llvm, not a versioned one, I just hadn't realised the llvm in f34 has been bumped, I'll rework this to be against that baseline instead of llvm10.
Spec URL: https://fedorapeople.org/~airlied/spirv-llvm-translator/spirv-llvm-translator.spec SRPM URL: https://fedorapeople.org/~airlied/spirv-llvm-translator/spirv-llvm-translator-11.0.0-0.1.fc34.src.rpm Description: LLVM to SPIRV IR translator Fedora Account System Username: airlied Update to f34 version built from the current 11.0.0 branch. I've fixed the globbing to explicitly install version 11. -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/include/LLVMSPIRVLib/LLVMSPIRVLib.h -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/include/LLVMSPIRVLib/LLVMSPIRVOpts.h -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/include/LLVMSPIRVLib/LLVMSPIRVExtensions.inc -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/lib64/pkgconfig/LLVMSPIRVLib.pc -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/lib64/libLLVMSPIRVLib.so.11 -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/lib64/libLLVMSPIRVLib.so -- Installing: /builddir/build/BUILDROOT/spirv-llvm-translator-11.0.0-0.1.fc34.x86_64/usr/bin/llvm-spirv looks like it picks up the correct libdir with the spec as-is as long as you build against the base llvm which is what I want. I'll have to maintain a v10 for f32/33 once we get this landed.
Thanks for review, hopefully you can give a quick re-review of the updated package for f34, though the changes are pretty much the globbing and changing the git source.
Resetting.
- Don't glob so you can own the whole directory: %{_includedir}/LLVMSPIRVLib/ - Please also update the changelog entry %changelog * Wed Aug 19 2020 Dave Airlie <airlied> - 11.0.0-0.1 - Initial packages of v11.0.0 tag for LLVM 11.0.0 Package approved, please fix the aforementioned issues before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "[generated file]", "Khronos License". 552 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/spirv-llvm- translator/review-spirv-llvm-translator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in spirv- llvm-translator-devel , spirv-llvm-translator-tools [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: spirv-llvm-translator-11.0.0-0.1.fc34.x86_64.rpm spirv-llvm-translator-devel-11.0.0-0.1.fc34.x86_64.rpm spirv-llvm-translator-tools-11.0.0-0.1.fc34.x86_64.rpm spirv-llvm-translator-debuginfo-11.0.0-0.1.fc34.x86_64.rpm spirv-llvm-translator-debugsource-11.0.0-0.1.fc34.x86_64.rpm spirv-llvm-translator-11.0.0-0.1.fc34.src.rpm spirv-llvm-translator.x86_64: W: spelling-error %description -l en_US Khronos -> Kimonos spirv-llvm-translator.x86_64: W: spelling-error %description -l en_US libclc -> libel spirv-llvm-translator.x86_64: W: incoherent-version-in-changelog 10.0.0-1 ['11.0.0-0.1.fc34', '11.0.0-0.1'] spirv-llvm-translator.x86_64: W: shared-lib-calls-exit /usr/lib64/libLLVMSPIRVLib.so.11 exit.5 spirv-llvm-translator-devel.x86_64: W: no-documentation spirv-llvm-translator-tools.x86_64: W: no-documentation spirv-llvm-translator-tools.x86_64: W: no-manual-page-for-binary llvm-spirv spirv-llvm-translator.src: W: spelling-error %description -l en_US Khronos -> Kimonos spirv-llvm-translator.src: W: spelling-error %description -l en_US libclc -> libel 6 packages and 0 specfiles checked; 0 errors, 9 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/spirv-llvm-translator
Package is available in repos.