Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1870718

Summary:	Keep dialogs consistent with GWT by locating the primary action button to the left of the secondary action button
Product:	[oVirt] ovirt-engine	Reporter:	Sharon Gratch <sgratch>
Component:	ovirt-engine-ui-extensions	Assignee:	Scott Dickerson <sdickers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ivana Saranova <isaranov>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.2	CC:	bugs, isaranov, lleistne, sdickers
Target Milestone:	ovirt-4.4.3	Keywords:	Reopened
Target Release:	---	Flags:	pm-rhel: ovirt-4.4+ pm-rhel: planning_ack+ pm-rhel: devel_ack+ lleistne: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-ui-extensions-1.2.4-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-11 06:42:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sharon Gratch 2020-08-20 16:40:46 UTC

Description of problem:
For all GWT dialogs, the primary action button (e.g. "OK") is located to the left of the secondary action button (e.g. "Cancel"). In other words, the 'OK' button is located on the left and the 'Cancel' will be on the right side.
This is a general design rule that is also used on GWT.

But on ovirt-engine-ui-extensions dialogs, the buttons switched sides such that the primary action button (e.g. "OK") are located to the right of the secondary action button (e.g. "Cancel").
This should be fixed by replacing button sides for all ui-extensions dialogs. 



Version-Release number of selected component (if applicable):
ovirt-engine-ui-extensions-1.2.3-1

How reproducible:
100%

Steps to Reproduce:
1.open one of the ui-extensions dialog on webadmin, for example "Migrate VM"
2.check buttons locations

Actual results:
the 'Migrate' button is located on the right and the 'Cancel' is located on the left side.

Expected results:
the 'Migrate' button is located on the left and the 'Cancel' is located on the right side.

Comment 1 Sharon Gratch 2020-08-26 16:23:21 UTC

Check the following comment: https://github.com/oVirt/ovirt-web-ui/issues/1280#issuecomment-680983295

Comment 2 Scott Dickerson 2020-10-11 18:21:43 UTC

The visual changes for the 4 PF4 modals are available here: https://ibb.co/album/n7fd9n

https://ibb.co/G3DKYwX - copy host network
https://ibb.co/jv80KyC - manage vGPU
https://ibb.co/k38Kwwc - export vm
https://ibb.co/Z6DS4n7 - migrate vms

Comment 3 Sharon Gratch 2020-10-14 09:33:33 UTC

@Scott, Based on the purpose of keeping consistency with GWT style and till we'll migrate the cluster upgrade dialog to PF4 as well (not sure it will be soon), I think that this fix should be applied to the cluster upgrade dialog as well, the same as for the GWT "import VMs" wizard dialog and regardless tp PF4 or PF3 style.

Comment 4 Scott Dickerson 2020-10-15 15:07:47 UTC

(In reply to Sharon Gratch from comment #3)
> @Scott, Based on the purpose of keeping consistency with GWT style and till
> we'll migrate the cluster upgrade dialog to PF4 as well (not sure it will be
> soon), I think that this fix should be applied to the cluster upgrade dialog
> as well, the same as for the GWT "import VMs" wizard dialog and regardless
> tp PF4 or PF3 style.

Done in patch: https://gerrit.ovirt.org/111750
Screen shot: https://ibb.co/dMGrTpS

Comment 5 Sharon Gratch 2020-10-15 17:38:38 UTC

(In reply to Scott Dickerson from comment #4)
> (In reply to Sharon Gratch from comment #3)
> > @Scott, Based on the purpose of keeping consistency with GWT style and till
> > we'll migrate the cluster upgrade dialog to PF4 as well (not sure it will be
> > soon), I think that this fix should be applied to the cluster upgrade dialog
> > as well, the same as for the GWT "import VMs" wizard dialog and regardless
> > tp PF4 or PF3 style.
> 
> Done in patch: https://gerrit.ovirt.org/111750
> Screen shot: https://ibb.co/dMGrTpS

Merged, but it will be part of next ovirt-engine-ui-extensions build (not included in ovirt-engine-ui-extensions-1.2.4-1).

Comment 6 Ivana Saranova 2020-10-21 11:10:46 UTC

Moving back to modified as the fix isn't in the latest build for QE. Also removing the fixed in version as the fix isn't included in it. Please move to ON_QA if the build has been provided to QE.

Comment 7 Sharon Gratch 2020-10-21 12:55:47 UTC

Sorry for the misunderstanding caused by a not so clear explanation on comment 5:
This bug was originally opened for all ui-extensions dialogs, but was fixed in ovirt-engine-ui-extensions-1.2.4-1 for all dialogs except the "cluster upgrade" dialog.

We decided to fix that for "cluster upgrade" as well and the patch will be part of next ui-extensions build.

But I don't think we need to move this bug back to MODIFIED and wait for next build. We can verify all dialogs except "cluster upgrade" with build ovirt-engine-ui-extensions-1.2.4-1 and QE can decide if it worth opening a separate bug for verifying only the "cluster upgrade" buttons position on next build, once it will be released (probably for 4.4.4). 

WDYT?

Comment 8 Ivana Saranova 2020-10-21 14:29:47 UTC

Okay, sounds good. I'll open a separate bug for the cluster upgrade and move this back to ON_QA.

Comment 11 Ivana Saranova 2020-10-22 11:58:31 UTC

Steps:
1) Check that Cancel button is on the right side in copy host network, manage vGPU, export vm and migrate vms dialogues.

Results:
Cancel button is on the correct side.

Verified in:
ovirt-engine-ui-extensions-1.2.4-1.el8ev.noarch
ovirt-engine-4.4.3.7-0.22.el8ev.noarch

Comment 12 Ivana Saranova 2020-10-22 12:03:37 UTC

Created a separate bug for the cluster upgrade dialog here https://bugzilla.redhat.com/show_bug.cgi?id=1890498

Comment 13 Sandro Bonazzola 2020-11-11 06:42:31 UTC

This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.