Bug 1871095 - thrift (probably incorrectly) build-depends on flex-devel
Summary: thrift (probably incorrectly) build-depends on flex-devel
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: thrift
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christopher Tubbs
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-21 10:19 UTC by Arjun Shankar
Modified: 2020-09-18 03:05 UTC (History)
3 users (show)

Fixed In Version: thrift-0.13.0-7.fc34
Clone Of:
Environment:
Last Closed: 2020-09-18 03:05:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Arjun Shankar 2020-08-21 10:19:29 UTC
I'm filing this report because when I run the following command:
dnf repoquery --disablerepo="*" --enablerepo="*-source" --arch=src --whatdepends flex-devel

I see thrift listed among the results.

flex-devel used to provide only libfl.a, a static library.

As per Fedora packaging guidelines, a build dependency on a static library should be represented by depending on the -static subpackage, not the -devel one that might actually contain the static library:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables

I just changed the subpackage split of flex, and have obsoleted flex-devel.

Although build-dependent packages will continue to build, a build-dependency requiring libfl.a should now ideally build-depend on libfl-static. flex now also provides shared libraries, and a build-dependency on libfl.so, should now depend on libfl2 (shared library) and libfl2-devel (headers).

Comment 1 Orion Poplawski 2020-09-18 03:05:50 UTC
Turns out that thrift doesn't actually need to use libfl.a at all, so I've just dropped the BR completely.  Thanks.


Note You need to log in before you can comment on or make changes to this bug.