Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1871360

Summary: Taking an interface absent does not ignore invalid ip
Product: Red Hat Enterprise Linux 8 Reporter: Mingyu Shi <mshi>
Component: nmstateAssignee: Gris Ge <fge>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: low Docs Contact:
Priority: low    
Version: 8.3CC: ferferna, jiji, jishi, network-qe, till
Target Milestone: rcKeywords: Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:17:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mingyu Shi 2020-08-22 18:12:35 UTC
Description of problem:
When taking an interface absent, nmstate does not ignore invalid ip(mtu, mac, etc). It worked on an earlier version(at least nmstate-0.3.2-1)

Version-Release number of selected component (if applicable):
Verified with versions:
nmstate-0.3.4-12.el8.noarch
NetworkManager-1.26.0-6.el8.x86_64
DISTRO=RHEL-8.3.0-20200822.n.0
Linux ibm-x3650m4-01-vm-07.ibm2.lab.eng.bos.redhat.com 4.18.0-234.el8.x86_64 #1 SMP Thu Aug 20 10:25:32 EDT 2020 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:
100%

Steps to Reproduce:
cat << EOF > up.yaml
interfaces:
- name: dummy0
  type: dummy
  state: up
  ipv4:
    enabled: true
    address:
    - ip: 1.1.1.1
      prefix-length: 24
EOF

cat << EOF > absent.yaml
interfaces:
- name: dummy0
  type: dummy
  state: absent
  ipv4:
    enabled: true
    address:
    - ip: 1.1.1.1343434
      prefix-length: 24
  mtu: 1500
EOF

1. nmstatectl set up.yaml
2. nmstatectl set absent.yaml
3.

Actual results:
Failed

Expected results:
Successfully taking it absent

Additional info:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/libnmstate/iplib.py", line 66, in canonicalize_ip_address
    return ipaddress.ip_address(address).compressed
  File "/usr/lib64/python3.6/ipaddress.py", line 54, in ip_address
    address)
ValueError: '1.1.1.1343434' does not appear to be an IPv4 or IPv6 address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/nmstatectl", line 11, in <module>
    load_entry_point('nmstate==0.3.4', 'console_scripts', 'nmstatectl')()
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 67, in main
    return args.func(args)
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 256, in apply
    args.save_to_disk,
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 289, in apply_state
    save_to_disk=save_to_disk,
  File "/usr/lib/python3.6/site-packages/libnmstate/netapplier.py", line 69, in apply
    net_state = NetState(desired_state, current_state, save_to_disk)
  File "/usr/lib/python3.6/site-packages/libnmstate/net_state.py", line 40, in __init__
    save_to_disk,
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/ifaces.py", line 104, in __init__
    iface.pre_edit_validation_and_cleanup()
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/base_iface.py", line 211, in pre_edit_validation_and_cleanup
    self.ip_state(family).validate(
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/base_iface.py", line 188, in ip_state
    return IPState(family, self._info.get(family, {}))
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/base_iface.py", line 46, in __init__
    self._canonicalize_ip_addr()
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/base_iface.py", line 66, in _canonicalize_ip_addr
    addr[InterfaceIP.ADDRESS_IP]
  File "/usr/lib/python3.6/site-packages/libnmstate/iplib.py", line 68, in canonicalize_ip_address
    raise NmstateValueError(f"Invalid IP address: {e}")
libnmstate.error.NmstateValueError: Invalid IP address: '1.1.1.1343434' does not appear to be an IPv4 or IPv6 address

Comment 2 Mingyu Shi 2021-01-18 12:04:24 UTC
Tested with:
nmstate-1.0.1-0.20210115115643933056.pr1478.27.gc9b2298.el8.noarch
nispor-1.0.1-2.el8.x86_64
NetworkManager-1.30.0-0.5.el8.x86_64

Run test 'ovs_option_test'

Comment 5 Mingyu Shi 2021-01-20 09:33:10 UTC
Verified with versions:
nmstate-1.0.1-1.el8.noarch
nispor-1.0.1-2.el8.x86_64
NetworkManager-1.30.0-0.5.el8.x86_64

Comment 7 errata-xmlrpc 2021-05-18 15:17:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1748