Container Build Info URL: https://github.com/thoth-station/thoth-toolbox Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos Fedora Account System Username: goern
I don't understand, what are you expecting from this bug in Review Request, if we don't have anything to review?
Container review request shouldn't be here. See: https://fedoraproject.org/wiki/Container:Review_Process
Changed format, this should make fedpkg happy. Most thing are just in same structure as what [toolbox] it self do, expect the name part, which I think is of no importance.(which I will confirm later) [toolbox]: https://src.fedoraproject.org/container/fedora-toolbox/blob/master/f/Dockerfile
While I think using pip is not a good idea,since you are using something that haven't packaged into package collection yet, this is not compliance with guideline: https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowed_content What you need to do then - check if those pip packages have already been packaged, if so, use dnf to install instead of pip - if not so, package them (you can look for help from devel list) - ping me if those are done :)
- The .osbs-repo-config file is not needed: Fedora's OSBS has no autorebuilds enabled. - pip content is not allowed, as per the guidelines as Qiyu pointed out. - The version should be set to 0 according to the guidelines. Alternatively, you should install specific versions of the package so a rebuild won't turn your version into a bogus one. - You could move the README.md to a help.md file and it should be converted to a man page in the image's root.
Hey all thanks for the review. I will work on the findings. I think I followed https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowed_content and interpreted "SHOULD NOT container" as... should not, rather than MUST NOT.