Bug 1872441 - inconsistent result set between views without tag information and views with tag information
Summary: inconsistent result set between views without tag information and views with ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Database.Core
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.4.3
: 4.4.3.3
Assignee: Eli Mesika
QA Contact: Guilherme Santos
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-25 17:49 UTC by Eli Mesika
Modified: 2020-11-11 06:53 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.4.3.3
Clone Of:
Environment:
Last Closed: 2020-10-26 07:31:09 UTC
oVirt Team: Infra
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)
views without tag information (9.44 KB, text/plain)
2020-08-25 17:50 UTC, Eli Mesika
no flags Details
views with tag information (11.20 KB, text/plain)
2020-08-25 17:50 UTC, Eli Mesika
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 111003 0 master MERGED db: fix inconsistent views 2020-11-11 06:45:14 UTC

Description Eli Mesika 2020-08-25 17:49:21 UTC
Description of problem:

Search engine uses the following views :

vdc_users
vds
vms

and their corresponding versions that includes tag information :

vdc_users_with_tags
vds_with_tags
vms_with_tags

The result set returned by a view and its corresponding tag support versions should be similar except of fields that are related to the tag support itself.

However, along the time there were some fields that are not related to tags and are omitted from the view or its corresponding tag support version


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.compare the attached no_tags.txt output that lists the columns of vdc_users, vds, vms views with with_tags.txt that lists teh corresponding vdc_users_with_tags, vds_with_tags, vms_with_tags with a tool like meld 
2.
3.

Actual results:

Some columns that are not related to tags are omitted 


Expected results:

Result set should be similar except columns related to tag support 


Additional info:

the "*_with_tags" views are used only from the search engine that generates dynamic sql , therefor we should insure that the result sets are the same up to tag support in order to prevent searching for columns that are not exists in the view

Comment 1 Eli Mesika 2020-08-25 17:50:15 UTC
Created attachment 1712581 [details]
views without tag information

Comment 2 Eli Mesika 2020-08-25 17:50:55 UTC
Created attachment 1712582 [details]
views with tag information

Comment 3 Eli Mesika 2020-08-25 18:12:43 UTC
The following are list of fields that exists in one view and missing from its corresponding tag support version and vise versa.
each such field should be investigated and added to the relevant view if needed 




vdc_users :
==========

external_id
namespace


vdc_users_with_tags :
======================

mla_role
vm_guid
vm_pool_name


vds :
======

cluster_gluster_service
cluster_virt_service
enable_balloon
gluster_peer_status
hbas
host_provider_id
hw_manufacturer
is_hosted_engine_host
kernel_cmdline
kernel_features
last_stored_kernel_cmdline
openstack_network_provider_id
recoverable
reinstall_required
sshkeyfingerprint
supported_emulated_machines
vds_spm_priority


vds_with_tags :
=================
storage_id


vms :
=======

changed_fields
cpu_pinning
db_generation
guest_agent_nics_hash
hash
host_cpu_flags
is_run_once
iso_path
last_watchdog_action
last_watchdog_event
migration_support
origin
predefined_properties
provider_id
quota_enforcement_type
transparent_hugepages
trusted_service
userdefined_properties
volatile_run


vms_with_tags :
=================

storage_id

Comment 4 Eli Mesika 2020-08-27 07:53:48 UTC
Here is the full list of changes that should be applied :

Legend :
=========

+ This field is in regular view and is missing in the view that includes tag support and can be added without any risk 

- This field is in the view that supports tag and is missing from the regular view because it is part of the tag support 

* This field is in regular view and is missing in the view that includes tag support but will not be added for a reason (adding JOIN/S for example)

 



vdc_users :
==========

external_id +
namespace +


vdc_users_with_tags :
======================

mla_role -
vm_guid -
vm_pool_name -


vds :
======

cluster_gluster_service +
cluster_virt_service +
enable_balloon +
gluster_peer_status * (need additional JOIN/S)
hbas +
host_provider_id +
hw_manufacturer +
is_hosted_engine_host * (need additional JOIN/S)
kernel_cmdline +
kernel_features +
last_stored_kernel_cmdline +
openstack_network_provider_id +
recoverable +
reinstall_required +
sshkeyfingerprint +
supported_emulated_machines +
vds_spm_priority +


vds_with_tags :
=================
storage_id -


vms :
=======

changed_fields +
cpu_pinning +
db_generation +
guest_agent_nics_hash +
hash +
host_cpu_flags +
is_run_once +
iso_path +
last_watchdog_action +
last_watchdog_event +
migration_support +
origin +
predefined_properties +
provider_id +
quota_enforcement_type +
transparent_hugepages +
trusted_service +
userdefined_properties +
volatile_run +


vms_with_tags :
=================

storage_id -

Comment 6 Sandro Bonazzola 2020-11-11 06:45:34 UTC
This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.