Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1874587 - Tags values in report are not escaped - can potentially cause JSON to be invalid
Summary: Tags values in report are not escaped - can potentially cause JSON to be invalid
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: RH Cloud - Inventory
Version: 6.8.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: 6.10.0
Assignee: Shimon Shtein
QA Contact: Jameer Pathan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-01 17:01 UTC by Mirek Długosz
Modified: 2021-11-16 14:09 UTC (History)
2 users (show)

Fixed In Version: tfm-rubygem-foreman_rh_cloud-3.0.18
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-16 14:09:27 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2021:4702 0 None None None 2021-11-16 14:09:35 UTC

Description Mirek Długosz 2020-09-01 17:01:22 UTC 
In generated report slice, we include various Satellite facts inside "tags" object. These values are not escaped and can potentially cause JSON to be invalid.

As example, following is perfectly valid host collection name for Satellite:

     my host collection " double quote


Inventory plugin will take that value verbatim and produce following JSON:

#v+
"tags": [
{"namespace": "satellite",
 "key": "host_collection",
 "value": "my host collection " double quote"}
]
#v-

This, of course, is not valid JSON - double quotes are not balanced and parser might assume that only `my host collection ` is "value" content - and what follows will cause parser to trip.


I verified that on host collection and organization name, but most likely same issue is present  for lifecycle environment, content view, activation key, location and hostgroup. All these fields come from user and we should treat them as potentially invalid.


Found on:
Satellite 6.8 snap 13
pulp-server-2.21.2-1.el7sat.noarch
foreman-2.1.2.1-1.el7sat.noarch
katello-3.16.0-0.4.rc4.el7sat.noarch
satellite-6.8.0-1.el7sat.noarch
tfm-rubygem-foreman_rh_cloud-2.0.10-1.el7sat.noarch
Comment 1 Jameer Pathan 2021-07-02 15:41:04 UTC 
Verified

Verified with:
- Satellite 6.10.0 snap 6
- tfm-rubygem-foreman_rh_cloud-4.0.22-1.el7sat.noarch

Test steps:
- Create Organization, Location, Content view, Lifecycle environment, Hostgroup, 
Host collection and Activation key entities with name containing " (double quote) in it.
- Register a content host with satellite using entities created.
- Generate Inventory report.

Observation:
- Valid json report is generated.
- Tag values are escaped properly.
- Host uploaded to c.r.c

Tags from generated json file:

{
    "key": "location",
    "namespace": "satellite",
    "value": "'location \" ' insights'"
},
{
    "key": "location",
    "namespace": "satellite",
    "value": "'location \" ' insights'"
},
{
    "key": "hostgroup",
    "namespace": "satellite",
    "value": "\"host '' group insights\""
},
{
    "key": "hostgroup",
    "namespace": "satellite",
    "value": "\"host '' group insights\""
},
{
    "key": "host collection",
    "namespace": "satellite",
    "value": "hc \" insights ' ' \""
},
{
    "key": "organization",
    "namespace": "satellite",
    "value": "\"organiztion ' ' insights\""
},
{
    "key": "lifecycle_environment",
    "namespace": "satellite",
    "value": "lifecycle ' ' env \" insights"
},
{
    "key": "content_view",
    "namespace": "satellite",
    "value": "cv \" insights \""
},
Comment 4 errata-xmlrpc 2021-11-16 14:09:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702
Note You need to log in before you can comment on or make changes to this bug.