Bug 1874638 - Missing logging for nbctl daemon
Summary: Missing logging for nbctl daemon
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.7.0
Assignee: Andrew Stoycos
QA Contact: Ross Brattain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-01 20:01 UTC by Tim Rozet
Modified: 2021-02-24 15:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:17:02 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-network-operator pull 772 0 None closed Bug 1874638: Fixes missing nbctl daemon logging 2021-02-11 18:57:41 UTC
Github openshift cluster-network-operator pull 914 0 None closed Bug 1874638: Add -F flag for ovn-nbctl logging 2021-02-11 18:57:41 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:17:26 UTC

Description Tim Rozet 2020-09-01 20:01:35 UTC
Description of problem:
We log daemon output upstream, which helps us identify nbctl cmds issued. We should also be logging it downstream.

Comment 2 Anurag saxena 2020-11-10 14:25:04 UTC
@rbrattai Can you help verifying it?

Comment 3 Ross Brattain 2020-11-13 20:26:38 UTC
-f --retry is --follow=descriptor --retry whereas the usual -F is --follow=name --retry

       -f, --follow[={name|descriptor}]
              output appended data as the file grows;

              an absent option argument means 'descriptor'
We usually want --follow=name, is there a reason we are only following descriptor.

Also, do we want --pid=$(cat /var/run/ovn/ovn-nbctl.pid) as in the other tail commands to stop the tail once the daemon stops?

Comment 4 Ross Brattain 2020-11-13 21:02:03 UTC
I guess --pid won't work if there is a delay in starting ovn-nbctl and the pid file doesn't exist.

Comment 7 Ross Brattain 2020-12-18 19:00:40 UTC
Verified on 4.7.0-0.nightly-2020-12-18-031435

Comment 9 errata-xmlrpc 2021-02-24 15:17:02 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.