Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte-1.12.0-1.fc32.src.rpm Description: Grammalecte is a grammar checker for the French language, derived from Lightproof. Grammalecte helps writing a proper French, without distracting users with false positives. This grammar checker follows the principle: the less false positives, the better; if it cannot know with a good chance that a dubious expression is wrong, it keeps silent. Fedora Account System Username: melmorabity
- Please also mention these licenses and add a comment explaining the license breakdown. Mozilla Public License 2.0 -------------------------- grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-classique.aff grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-reforme1990.aff grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-toutesvariantes.aff grammalecte-1.12.0/lexicons/French.lex SIL Open Font License 1.1 ------------------------- grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Bold.otf grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Light.otf grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Regular.otf grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Thin.otf - Please add a short comment explaining why you need to disable debuginfo
Thanks for your comments. Spec URL: https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/grammalecte/grammalecte-1.12.2-1.fc32.src.rpm (In reply to Robert-André Mauchin 🐧 from comment #1) > - Please also mention these licenses and add a comment explaining the > license breakdown. > > Mozilla Public License 2.0 > -------------------------- > grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-classique.aff > grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr-reforme1990. > aff > grammalecte-1.12.0/gc_lang/fr/oxt/Dictionnaires/dictionaries/fr- > toutesvariantes.aff > grammalecte-1.12.0/lexicons/French.lex I updated the License tag to add MPLv2.0 license, as well as LGPLv2+ for hyphenation rule+thesaurus files. I also added comments to clarify the license BD. > > SIL Open Font License 1.1 > ------------------------- > grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Bold.otf > grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Light.otf > grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Regular.otf > grammalecte-1.12.0/gc_lang/fr/webext/fonts/YanoneKaffeesatz-Thin.otf Those files are not packaged (they're part of the JS implementation of Grammalecte for Firefox and Thunderbird extensions; I don't package them since they require NodeJS resources, especially web-ext, not available on Fedora). > - Please add a short comment explaining why you need to disable debuginfo LibreOffice doesn't provide an arch-independent extension directory for non-binary extensions. I added a comment about it in the SPEC file
Sorry, I forgot to paste the review on the comment above: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Mozilla Public License 2.0", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License, Version 3", "GNU General Public License", "BSD 3-clause "New" or "Revised" License", "LaTeX Project Public License GNU Lesser General Public License, Version 2.1", "SIL Open Font License 1.1". 314 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/grammalecte/review- grammalecte/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libreoffice-grammalecte , python3-grammalecte [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libreoffice-grammalecte-1.12.0-1.fc34.x86_64.rpm python3-grammalecte-1.12.0-1.fc34.noarch.rpm grammalecte-1.12.0-1.fc34.src.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Package is approved.
Thanks again for this excellent review Robert-André ;)
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/grammalecte
FEDORA-2020-a0d633d6f4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a0d633d6f4
FEDORA-2020-a3154f41a1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a3154f41a1
FEDORA-2020-b6f3bee346 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b6f3bee346
FEDORA-2020-a3154f41a1 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a3154f41a1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a3154f41a1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-b6f3bee346 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b6f3bee346 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b6f3bee346 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-a0d633d6f4 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a0d633d6f4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a0d633d6f4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-a3154f41a1 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-b6f3bee346 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-a0d633d6f4 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.