RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1874877 - Packet marks and icmptypes in rich rules handling fixes for both backends
Summary: Packet marks and icmptypes in rich rules handling fixes for both backends
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: firewalld
Version: 8.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: 8.0
Assignee: Eric Garver
QA Contact: Tomas Dolezal
URL:
Whiteboard:
: 1707483 (view as bug list)
Depends On:
Blocks: 1875967 1894575
TreeView+ depends on / blocked
 
Reported: 2020-09-02 13:35 UTC by Tomas Dolezal
Modified: 2021-05-18 14:58 UTC (History)
4 users (show)

Fixed In Version: firewalld-0.8.2-3.el8
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-18 14:58:48 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tomas Dolezal 2020-09-02 13:35:22 UTC
Description of problem:
Based on issues found in bz1855140:
 1. packet marks with masks broken in nftables backend (bug 1855140 comment 12)
 2. conflicting rich rule family and icmptype ip families (bug 1855140 comment 7)
https://github.com/firewalld/firewalld/pull/686

tests added with commits from the PR (includes coverage of marks and their /masks)
also:
/CoreOS/firewalld/Regression/rich-rules-unable-to-act-upon-icmp-packets (/masks were dropped from marks tests)
/CoreOS/firewalld/Regression/icmptypes-family-validity


Version-Release number of selected component (if applicable):
firewalld-0.8.2-2.el8

How reproducible:
always

Steps to Reproduce:
firewall-cmd --add-rich-rule 'rule family=ipv6 icmp-type name=timestamp-request drop'

Actual results:
Error: COMMAND_FAILED and missing rules for certain combinations with iptables/nftables backend

Expected results:
success/specific firewalld error

Additional info:

Comment 2 Eric Garver 2020-09-02 14:32:16 UTC
Upstream commits:

54f2e490d422 ("test(features/rich_rules): add packet marks with masks")
cb904420da30 ("test(regression/rhbz1855140): add negative tests")
b6f3b98efca6 ("fix(nftables): icmp types with code == 0")
9d128274ee33 ("fix(nftables): packet marks with masks")
5ce18b613181 ("fix(rich icmptype): verify rule and icmptype families don't conflict")

Comment 3 Eric Garver 2020-09-02 17:01:37 UTC
Correct upstream commits:

22f8053f06ee ("test(features/rich_rules): add packet marks with masks")
b50032185422 ("test(regression/rhbz1855140): add negative tests")
098e35168d6a ("fix(nftables): icmp types with code == 0")
e296b926ae5d ("fix(nftables): packet marks with masks")
11aac7755d9c ("fix(rich icmptype): verify rule and icmptype families don't conflict")

Comment 13 Tomas Dolezal 2020-12-02 20:03:49 UTC
*** Bug 1707483 has been marked as a duplicate of this bug. ***

Comment 15 errata-xmlrpc 2021-05-18 14:58:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (firewalld bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1643


Note You need to log in before you can comment on or make changes to this bug.