Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1874880

Summary:	Update column settings to contain only relevant columns
Product:	[oVirt] ovirt-engine-dwh	Reporter:	Aviv Litman <alitman>
Component:	Grafana	Assignee:	Aviv Litman <alitman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Novotny <pnovotny>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.4.1	Flags:	pm-rhel: ovirt-4.4+ pm-rhel: planning_ack+ pm-rhel: devel_ack+ lleistne: testing_ack+
Target Milestone:	ovirt-4.4.3
Target Release:	4.4.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-dwh-4.4.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-01 21:01:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1879377

Description Aviv Litman 2020-09-02 13:45:28 UTC

Description of problem:
We want to remove unnecessary column settings so that the user can see in each panel only the relevant settings.

Version-Release number of selected component (if applicable):
4.4.1

How reproducible:
100%

Steps to Reproduce:
1. go to Grafana and choose a dashboard
2. choose a report (table) and press 'Edit'
3. 'Visualization' -> 'Column Styles'

Actual results:
In some panels the settings of 'Column Styles' contains unnecessary column settings.


Expected results:
All panels contain settings for columns relevant to the panel only.

Additional info:
This bug can be seen in the Inventory Dashboard

Comment 1 Pavel Novotny 2020-11-01 20:42:54 UTC

I've found several tables with extra columns in the Visualization settings / Column Styles that are not present in the table itself.

For example: oVirt Inventory Dashboards > Inventory Dashboard: table 'Memory Usage and Overcommit (BR48)' (applies also for the other tables in this dashboard).
There is a 'Hidden' Type column named 'datacenter_description' that is not present in the table.

Example#2: Hosts Inventory Dashboard: table Hosts Inventory (BR1) - extra hidden column 'cluster_id'.


Should be these columns removed from the Columns Styles as well or they are needed for the tables to function properly?

Comment 3 Aviv Litman 2020-11-04 09:51:37 UTC

(In reply to Pavel Novotny from comment #1)
> I've found several tables with extra columns in the Visualization settings /
> Column Styles that are not present in the table itself.
> 
> For example: oVirt Inventory Dashboards > Inventory Dashboard: table 'Memory
> Usage and Overcommit (BR48)' (applies also for the other tables in this
> dashboard).
> There is a 'Hidden' Type column named 'datacenter_description' that is not
> present in the table.
> 
> Example#2: Hosts Inventory Dashboard: table Hosts Inventory (BR1) - extra
> hidden column 'cluster_id'.
> 
> 
> Should be these columns removed from the Columns Styles as well or they are
> needed for the tables to function properly?

Hi this bug was designed to remove unnecessary columns that are not hidden, 
these columns whether you hide them or not - will not appear in the report and have therefore been removed.
The hidden columns that were left - if you change the hiding will appear in the report, 
so it was decided to leave them in order to leave the option to see them if necessary.

Comment 4 Pavel Novotny 2020-11-04 10:44:19 UTC

(In reply to Aviv Litman from comment #3)
> (In reply to Pavel Novotny from comment #1)
> > I've found several tables with extra columns in the Visualization settings /
> > Column Styles that are not present in the table itself.
> > 
> > For example: oVirt Inventory Dashboards > Inventory Dashboard: table 'Memory
> > Usage and Overcommit (BR48)' (applies also for the other tables in this
> > dashboard).
> > There is a 'Hidden' Type column named 'datacenter_description' that is not
> > present in the table.
> > 
> > Example#2: Hosts Inventory Dashboard: table Hosts Inventory (BR1) - extra
> > hidden column 'cluster_id'.
> > 
> > 
> > Should be these columns removed from the Columns Styles as well or they are
> > needed for the tables to function properly?
> 
> Hi this bug was designed to remove unnecessary columns that are not hidden, 
> these columns whether you hide them or not - will not appear in the report
> and have therefore been removed.
> The hidden columns that were left - if you change the hiding will appear in
> the report, 
> so it was decided to leave them in order to leave the option to see them if
> necessary.

Ok, thanks for the clarification.
Then consider this bug as VERIFIED (ovirt-engine-4.4.3.8-0.1.el8ev ovirt-engine-dwh-4.4.3.1-1.el8ev).

Comment 5 Sandro Bonazzola 2020-11-11 06:45:35 UTC

This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.