Bug 187498 - diskdump_sysfs_store() needs to check sscanf retval
Summary: diskdump_sysfs_store() needs to check sscanf retval
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel   
(Show other bugs)
Version: 4.0
Hardware: All
OS: Linux
Target Milestone: ---
: ---
Assignee: Alexander Viro
QA Contact: Brian Brock
Depends On:
Blocks: 161161 181409
TreeView+ depends on / blocked
Reported: 2006-03-31 13:17 UTC by Tim Burke
Modified: 2007-11-30 22:07 UTC (History)
2 users (show)

Fixed In Version: RHSA-2006-0575
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-08-10 22:59:50 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2006:0575 normal SHIPPED_LIVE Important: Updated kernel packages available for Red Hat Enterprise Linux 4 Update 4 2006-08-10 04:00:00 UTC

Description Tim Burke 2006-03-31 13:17:25 UTC
kernel/dump.c::diskdump_sysfs_store() calls sscanf(..., "%d", &part) but
doesn't check that it had returned 1.  It proceeds to use the value of part
unconditionally; if string wasn't a number, part will be used uninitialized.
Fix: add the check, return -EINVAL if it fails.

Comment 1 Bob Johnson 2006-04-11 17:11:08 UTC
This issue is on Red Hat Engineering's list of planned work items 
for the upcoming Red Hat Enterprise Linux 4.4 release.  Engineering 
resources have been assigned and barring unforeseen circumstances, Red 
Hat intends to include this item in the 4.4 release.

Comment 2 Jason Baron 2006-04-21 03:24:43 UTC
committed in stream U4 build 34.21. A test kernel with this patch is available
from http://people.redhat.com/~jbaron/rhel4/

Comment 5 Red Hat Bugzilla 2006-08-10 22:59:52 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.