Bug 1875191
| Summary: | logging-fluentd ConfigMap is overwritten during logging stack upgrades | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Michael Burke <mburke> |
| Component: | Documentation | Assignee: | Michael Burke <mburke> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Anping Li <anli> |
| Severity: | medium | Docs Contact: | Vikram Goyal <vigoyal> |
| Priority: | medium | ||
| Version: | 3.11.0 | CC: | anli, aos-bugs, ewolinet, jmalde, jokerman, ocasalsa |
| Target Milestone: | --- | ||
| Target Release: | 3.11.z | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1856435 | Environment: | |
| Last Closed: | 2020-09-29 14:14:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1856435 | ||
| Bug Blocks: | |||
|
Comment 1
Michael Burke
2020-09-03 01:05:45 UTC
Hello Michael, Thank you so much for opening the PR. I have reviewed it and something sounds weird from my side. It seems that you have copied the curator documentation for the parameter `openshift_logging_curator_replace_configmap`, but this is for the new parameter `openshift_logging_fluentd_replace_configmap`, then, we'll need to replace the references to curator for fluentd. Let me know if my words are understandable for you like this: The upgrade can override your `logging-fluentd` ConfigMap. If you want to retain your current `logging-fluentd` ConfigMap, set the `openshift_logging_fluentd_replace_configmap` parameter to `no` in the the xref:../install/configuring_inventory_file.adoc#configuring-ansible[inventory host file]. On the other side, I believe from this PR [1] that the default value is to be not overwritten: ~~~ # If this is set to true then the logging-fluentd configmap will be overridden # by the default values. If set to false, the existing logging-fluentd # configmap will be left in tact. openshift_logging_fluentd_replace_configmap: no ~~~ Then, it's the default behaviour and it should be put to true if you want to overwrite it. Regards, Oscar [1] https://github.com/openshift/openshift-ansible/pull/12206/files Oscar -- Than you. I was looking at the PR added to the original BZ that added the `openshift_logging_curator_replace_configmap` parameter. I was confused, as the request was to add a `openshift_logging_fluentd_replace_configmap`. However, there was no one on line to help clarify. I have an question in Slack with Eric W of the logging team. The PR you included today has clarified. Both parameters were added on the same day. I decided to add the curator parameter to the docs also. And have just added the fluentd parameter. Please take a look. Thank you for pointing out these omissions. Michael Anping -- You reviewed the PRs that added these new parameters. Can you review the docs for the parameters? Thank you, Michael Hello Michael, It makes sense the confussion if both of them were added to the same time. Great job people. Thanks, Oscar |