Bug 187570 - metacity crashes on shutdown
Summary: metacity crashes on shutdown
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: metacity
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Søren Sandmann Pedersen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-04-01 01:35 UTC by David Baron
Modified: 2014-06-18 09:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-06 19:54:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Baron 2006-04-01 01:35:54 UTC
Description of problem:  metacity crashes on shutdown, I think pretty much every
time I log out.  The only symptom is that it leaves a core file (and that only
because I have coredumpsize unlimited.)

Version-Release number of selected component (if applicable):
metacity-2.14.0-1

How reproducible:  Always, I think.

Steps to Reproduce:
1. create an .Xclients with:

#!/bin/bash
ulimit -c unlimited
exec /etc/X11/init/Xclients

2. log in to GNOME
3. log out
  
Actual results: metacity generates a core file

Expected results: no core file

Additional info:

The stack is:

#0  meta_compositor_unref (compositor=0x0) at compositor.c:162
#1  0x0805e020 in meta_display_close (display=0x8ae4100) at display.c:926
#2  0x0807086c in main (argc=1, argv=0xbfe4a274) at main.c:505
#3  0x00f617e4 in __libc_start_main (main=0x8070100 <main>, argc=3,
    ubp_av=0xbfe4a274, init=0x80aeafc <__libc_csu_init>,
    fini=0x80aeaf4 <__libc_csu_fini>, rtld_fini=0x34ee40 <_dl_fini>,
    stack_end=0xbfe4a26c) at libc-start.c:231
#4  0x08053bb1 in _start ()

which indicates that this is a problem in the metacity-2.13.144-bling.patch that
is being applied by the FC5 distribution.  All other uses of display->compositor
seem to be null-checked (as applying that patch requires), but the line:
display.c:926       meta_compositor_unref (display->compositor);
is not surrounded by a null-check of display->compositor.  Fixing this patch to
add a null-check seems like the right fix, although I haven't tested it.


Note You need to log in before you can comment on or make changes to this bug.