Fedora Account System
Red Hat Associate
Red Hat Customer
Description of problem: I'm using Firefox with KDE & X11. Firefox won't restart after update and clicking "Restart Firefox" on the "about:restartrequired" page. Version-Release number of selected component (if applicable): firefox-80.0.1-2.fc32.x86_64 How reproducible: Steps to Reproduce: 1. Start firefox; 2. Do "sudo dnf reinstall firefox"; 3. Open page "about:restartrequired" and click "Restart Firefox". Actual results: Firefox won't start after that. It just exits. Expected results: Firefox will restart as intended.
If I just click on "Restart Firefox" without doing "dnf reinstall" - Firefox restarts without any issues.
I suspect the restart it not guarranted to work after Firefox reinstall by dnf.
And not guarranted after firefox package update?
Possible duplicate: https://bugzilla.redhat.com/show_bug.cgi?id=1804293.
I've got this when running firefox under strace & doing "Restart Firefox" after reinstall: ``` readlink("/proc/self/exe", "/usr/lib64/firefox/firefox (dele"..., 4095) = 36 execve("/usr/lib64/firefox/firefox (deleted)", ["/usr/lib64/firefox/firefox"], 0x7f0aad04f000 /* 112 vars */) = -1 ENOENT (No such file or directory) ```
Mozilla binaries use a different mechanism than dnf to update Firefox. dnf just replaces the whole package, original files are deleted and replaces by the new ones so you see the missing file error.
Firefox code that was calling readlink is not taking into account that returned path on Linux can include postfix " (deleted)". (see: https://stackoverflow.com/a/58105245). And because returned path ends with "firefox (deleted)" - we got ENOENT later, when calling execve.
Created attachment 1714070 [details] firefox-fix-restart.patch This small patch removes postfix " (deleted)" from the exe path, so issue with restart will be fixed. I'll test it later, rebuilding Firefox with mock takes huge amount of time on my machine.
Can you please file that patch upstream at bugzilla.mozilla.org and cc me there? Thanks!
Just tested the patch after rebuilding firefox - it's working as expected. I found this issue on the bugzilla.mozilla.org about same bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1550074. See my comments & patch. You're already in the CC list. But that bug still in UNCONFIRMED state :(
This message is a reminder that Fedora 32 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '32'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 32 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 32 changed to end-of-life (EOL) status on 2021-05-25. Fedora 32 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.