Bug 1876259 - Review Request: perl-URI-cpan - URLs that refer to things on the CPAN
Summary: Review Request: perl-URI-cpan - URLs that refer to things on the CPAN
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1878990
TreeView+ depends on / blocked
 
Reported: 2020-09-06 19:07 UTC by Paul Howarth
Modified: 2020-10-01 01:41 UTC (History)
2 users (show)

Fixed In Version: perl-URI-cpan-1.007-4.fc34
Clone Of:
Environment:
Last Closed: 2020-09-23 17:12:09 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Paul Howarth 2020-09-06 19:07:57 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-URI-cpan/branches/fedora/perl-URI-cpan.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-URI-cpan/perl-URI-cpan-1.007-2.fc34.src.rpm
Description:
This module is for handling URLs that refer to things on the CPAN.

Fedora Account System Username: pghmcfc

This is needed to update perl-Perl-PrereqScanner-NotQuiteLite to the current upstream release.

Comment 1 Petr Pisar 2020-09-15 13:50:49 UTC
The URL and Source0 addresses are Ok.
The Source0 archive (SHA-256: 125a1394662e0a45e2696977496c1d027b14387ff6e39b60c07e0f96eae152d3) is original. Ok.
Summary verified from lib/URI/cpan.pm. Ok.
Description is Ok.
License verified from lib/URI/cpan/distfile.pm, lib/URI/cpan/package.pm, lib/URI/cpan/module.pm, lib/URI/cpan/author.pm, lib/URI/cpan/dist.pm, lib/URI/cpan.pm, Makefile.PL, LICENSE, and README. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Consider using %{make_install} macro with Makefile.PL NO_PACKLIST=1 NO_PERLLOCAL=1.
FIX: Move 'perl(URI)' BuildRequires to tests section (t/uri-cpan.t:4). It's not used at a run-time.

All tests pass. Ok.

$ rpmlint perl-URI-cpan.spec ../SRPMS/perl-URI-cpan-1.007-2.fc34.src.rpm ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Sep 15 15:41 /usr/share/doc/perl-URI-cpan
-rw-r--r--    1 root     root                      632 Apr 17  2015 /usr/share/doc/perl-URI-cpan/Changes
-rw-r--r--    1 root     root                      372 Apr 17  2015 /usr/share/doc/perl-URI-cpan/README
drwxr-xr-x    2 root     root                        0 Sep 15 15:41 /usr/share/licenses/perl-URI-cpan
-rw-r--r--    1 root     root                    18355 Apr 17  2015 /usr/share/licenses/perl-URI-cpan/LICENSE
-rw-r--r--    1 root     root                     1796 Sep 15 15:41 /usr/share/man/man3/URI::cpan.3pm.gz
-rw-r--r--    1 root     root                     1298 Sep 15 15:41 /usr/share/man/man3/URI::cpan::author.3pm.gz
-rw-r--r--    1 root     root                     1296 Sep 15 15:41 /usr/share/man/man3/URI::cpan::dist.3pm.gz
-rw-r--r--    1 root     root                     1599 Sep 15 15:41 /usr/share/man/man3/URI::cpan::distfile.3pm.gz
-rw-r--r--    1 root     root                     1298 Sep 15 15:41 /usr/share/man/man3/URI::cpan::module.3pm.gz
-rw-r--r--    1 root     root                     1300 Sep 15 15:41 /usr/share/man/man3/URI::cpan::package.3pm.gz
drwxr-xr-x    2 root     root                        0 Sep 15 15:41 /usr/share/perl5/vendor_perl/URI
drwxr-xr-x    2 root     root                        0 Sep 15 15:41 /usr/share/perl5/vendor_perl/URI/cpan
-rw-r--r--    1 root     root                     3601 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan.pm
-rw-r--r--    1 root     root                      857 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan/author.pm
-rw-r--r--    1 root     root                      509 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan/dist.pm
-rw-r--r--    1 root     root                     2540 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan/distfile.pm
-rw-r--r--    1 root     root                      515 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan/module.pm
-rw-r--r--    1 root     root                      518 Apr 17  2015 /usr/share/perl5/vendor_perl/URI/cpan/package.pm

A file layout and the permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Carp)
      1 perl(CPAN::DistnameInfo)
      1 perl(parent)
      1 perl(strict)
      1 perl(URI::cpan)
      1 perl(URI::cpan::author)
      1 perl(URI::cpan::dist)
      1 perl(URI::cpan::distfile)
      1 perl(URI::cpan::module)
      1 perl(URI::cpan::package)
      1 perl(URI::_generic)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm | sort -f | uniq -c
      1 perl(URI::cpan) = 1.007
      1 perl(URI::cpan::author) = 1.007
      1 perl(URI::cpan::dist) = 1.007
      1 perl(URI::cpan::distfile) = 1.007
      1 perl(URI::cpan::module) = 1.007
      1 perl(URI::cpan::package) = 1.007
      1 perl-URI-cpan = 1.007-2.fc34
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-URI-cpan-1.007-2.fc34.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=51510948). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' item, and consider fixing the 'TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Paul Howarth 2020-09-15 15:22:43 UTC
Thanks Petr.

Repo request:
https://pagure.io/releng/fedora-scm-requests/issue/29079

I'll fix the perl(URI) categorisation on import.

I'll switch to %{make_install} after branching for epel7, which doesn't have a new enough EU::MM.

Comment 3 Gwyn Ciesla 2020-09-15 15:45:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-URI-cpan

Comment 4 Fedora Update System 2020-09-15 17:58:34 UTC
FEDORA-2020-bc55da4e50 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc55da4e50

Comment 5 Fedora Update System 2020-09-15 17:58:36 UTC
FEDORA-2020-5b408002a0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5b408002a0

Comment 6 Fedora Update System 2020-09-15 17:58:37 UTC
FEDORA-2020-1da58546d4 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1da58546d4

Comment 7 Fedora Update System 2020-09-16 14:30:13 UTC
FEDORA-2020-1da58546d4 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-1da58546d4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1da58546d4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-09-16 14:40:02 UTC
FEDORA-EPEL-2020-3cdcbc56e0 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-3cdcbc56e0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-09-16 14:58:29 UTC
FEDORA-EPEL-2020-8bb1d5473c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8bb1d5473c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-09-16 15:36:04 UTC
FEDORA-2020-bc55da4e50 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-bc55da4e50 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bc55da4e50

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-09-16 18:57:00 UTC
FEDORA-2020-5b408002a0 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5b408002a0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5b408002a0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-09-23 17:12:09 UTC
FEDORA-2020-1da58546d4 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-09-23 18:10:30 UTC
FEDORA-2020-bc55da4e50 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-09-25 16:58:59 UTC
FEDORA-2020-5b408002a0 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2020-10-01 00:30:55 UTC
FEDORA-EPEL-2020-3cdcbc56e0 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2020-10-01 01:41:57 UTC
FEDORA-EPEL-2020-8bb1d5473c has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.