Bug 1876578 - Review Request: python-kismet-rest - Python API for the Kismet REST interface
Summary: Review Request: python-kismet-rest - Python API for the Kismet REST interface
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andy Mender
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-SECLAB 1882303
TreeView+ depends on / blocked
 
Reported: 2020-09-07 15:02 UTC by Fabian Affolter
Modified: 2020-09-25 16:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-25 16:53:18 UTC
Type: ---
Embargoed:
andymenderunix: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-07 15:02:45 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-kismet-rest.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-kismet-rest-2019.5.2-1.fc32.src.rpm

Project URL: https://github.com/kismetwireless/python-kismet-rest

Description:
Python API wrapper for Kismet RESTful API interface.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=50946494

rpmlint output:
$ rpmlint python-kismet-rest-2019.5.2-1.fc32.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-kismet-rest-2019.5.2-1.fc32.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

Comment 1 Andy Mender 2020-09-07 18:12:01 UTC
I see the project has tests: https://github.com/kismetwireless/python-kismet-rest/tree/master/tests
Can you add them as a %check step if possible?

The rest looks good. Full review below:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License". 44
     files have unknown license. Detailed output of licensecheck in
     /home/amender/rpmbuild/SPECS/python-kismet-rest/python-kismet-
     rest/licensecheck.txt
     Review: LICENSE file picked up as LGPL, but it's actually GPLv2.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python3-kismet-rest-2019.5.2-1.fc34.noarch.rpm
          python-kismet-rest-2019.5.2-1.fc34.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
(none): E: no installed packages by name python3-kismet-rest
0 packages and 0 specfiles checked; 0 errors, 0 warnings.



Source checksums
----------------
https://github.com/kismetwireless/python-kismet-rest/archive/2019.05.02/kismet_rest-2019.05.02.tar.gz :
  CHECKSUM(SHA256) this package     : 6a26d0ce0f86501d93812e28744c0591441e1e114103cb5041431d7f6ea6f414
  CHECKSUM(SHA256) upstream package : 6a26d0ce0f86501d93812e28744c0591441e1e114103cb5041431d7f6ea6f414


Requires
--------
python3-kismet-rest (rpmlib, GLIBC filtered):
    python(abi)
    python3.9dist(requests)



Provides
--------
python3-kismet-rest:
    python-kismet-rest
    python3-kismet-rest
    python3.9-kismet-rest
    python3.9dist(kismet-rest)
    python3dist(kismet-rest)

Comment 2 Fabian Affolter 2020-09-07 19:02:51 UTC
(In reply to Andy Mender from comment #1)
> I see the project has tests:
> https://github.com/kismetwireless/python-kismet-rest/tree/master/tests
> Can you add them as a %check step if possible?

Not, possible as they require a running kismet instance. Upstream is using containers to do it but this will not work with the build system.

Comment 3 Fabian Affolter 2020-09-07 19:03:06 UTC
(In reply to Andy Mender from comment #1)
> I see the project has tests:
> https://github.com/kismetwireless/python-kismet-rest/tree/master/tests
> Can you add them as a %check step if possible?

Not, possible as they require a running kismet instance. Upstream is using containers to do it but this will not work with the build system.

Comment 4 Andy Mender 2020-09-07 19:33:44 UTC
> Not, possible as they require a running kismet instance. Upstream is using containers to do it but this will not work with the build system.

I see... I looked at the tests and assumed it's possible to have at least a local instance running for the tests. 

Package approved!

Comment 5 Igor Raits 2020-09-08 09:41:07 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-kismet-rest

Comment 6 Fedora Update System 2020-09-09 12:42:21 UTC
FEDORA-2020-9229f219ce has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9229f219ce

Comment 7 Fedora Update System 2020-09-10 15:48:11 UTC
FEDORA-2020-9229f219ce has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9229f219ce \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9229f219ce

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-09-25 16:53:18 UTC
FEDORA-2020-9229f219ce has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.