RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1876834 - No 'vst1q_f32_x2' intrinsic on AArch64
Summary: No 'vst1q_f32_x2' intrinsic on AArch64
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: gcc
Version: 8.3
Hardware: aarch64
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Marek Polacek
QA Contact: Alexandra Petlanová Hájková
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-08 10:07 UTC by Marcin Juszkiewicz
Modified: 2023-07-18 14:19 UTC (History)
7 users (show)

Fixed In Version: gcc-8.4.1-1.el8
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-18 13:28:00 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
patch against git.centos.org gcc repo (91.18 KB, application/mbox)
2020-09-08 10:07 UTC, Marcin Juszkiewicz
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github pytorch pytorch issues 44198 0 None closed error: ‘vst1q_f32_x2’ was not declared in this scope 2020-10-27 11:06:40 UTC
Github pytorch pytorch pull 44199 0 None closed handle missing NEON vst1_*_x2 intrinsics (#44198) 2020-10-27 11:06:26 UTC

Description Marcin Juszkiewicz 2020-09-08 10:07:26 UTC
Created attachment 1714068 [details]
patch against git.centos.org gcc repo

Description of problem:

Pytorch can not be built on AArch64 in CentOS 8. Build fails with:

/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:235:7: error: ‘vst1q_f32_x2’ was not declared in this scope

I filled bug against pytorch [1] and with help of Sebastian Pop did a fix [2]. But proper solution would be fixing it in gcc by backporting two patches.

1. https://github.com/pytorch/pytorch/issues/44198
2. https://github.com/pytorch/pytorch/pull/44199


Version-Release number of selected component (if applicable):

8.3.1-5.el8.0.2

How reproducible:

always

Steps to Reproduce:
1. Clone https://github.com/pytorch/pytorch
2. cd pytorch
3. USE_CUDA=0 BUILD_CAFFE2_OPS=0 USE_DISTRIBUTED=0 USE_QNNPACK=0 USE_XNNPACK=0 python3 setup.py install

Actual results:

In file included from /root/pytorch/aten/src/ATen/cpu/vec256/vec256.h:10,
                 from /root/pytorch/aten/src/ATen/native/cpu/Loops.h:35,
                 from /root/pytorch/aten/src/ATen/native/Normalization.cpp:10:
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:262:3: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   const float operator[](int idx) const {
   ^~~~~
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:267:3: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
   const float operator[](int idx) {
   ^~~~~
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h: In member function ‘void at::vec256::{anonymous}::Vec256<float>::store(void*, int64_t) const’:
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:235:7: error: ‘vst1q_f32_x2’ was not declared in this scope
       vst1q_f32_x2(reinterpret_cast<float*>(ptr), values);
       ^~~~~~~~~~~~
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:235:7: note: suggested alternative: ‘vld1q_f32_x2’
       vst1q_f32_x2(reinterpret_cast<float*>(ptr), values);
       ^~~~~~~~~~~~
       vld1q_f32_x2
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:242:7: error: ‘vst1q_f32_x2’ was not declared in this scope
       vst1q_f32_x2(reinterpret_cast<float*>(tmp_values), values);
       ^~~~~~~~~~~~
/root/pytorch/aten/src/ATen/cpu/vec256/vec256_float_neon.h:242:7: note: suggested alternative: ‘vld1q_f32_x2’
       vst1q_f32_x2(reinterpret_cast<float*>(tmp_values), values);
       ^~~~~~~~~~~~
       vld1q_f32_x2
gmake[2]: *** [caffe2/CMakeFiles/torch_cpu.dir/build.make:2014: caffe2/CMakeFiles/torch_cpu.dir/__/aten/src/ATen/native/Normalization.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:6058: caffe2/CMakeFiles/torch_cpu.dir/all] Error 2
gmake: *** [Makefile:141: all] Error 2

Expected results:

pytorch builds

Additional info:

Comment 2 Marek Polacek 2020-09-29 19:55:45 UTC
GCC 8.4 contains:

commit 2c55e6caa9432b2c1f081cb3aeddd36abec03233
Author: Sameera Deshpande <sameera.deshpande>
Date:   Thu May 31 08:46:20 2018 +0000

    Patch implementing vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics for AARCH64 for all types.

(cherry picked from commit 568421baa5a4cdb7bb7c5ac323c939492ee3f052)

and also
commit a4004f62d60ada3a20dbf30146ca461047a575cc
Author: Sylvia Taylor <sylvia.taylor>
Date:   Thu Aug 22 11:28:26 2019 +0000

    add intrinsics for vld1(q)_x4 and vst1(q)_x4
    
    This patch adds the intrinsic functions for:
    - vld1_<mode>_x4
    - vst1_<mode>_x4
    - vld1q_<mode>_x4
    - vst1q_<mode>_x4

(cherry picked from commit 391625888d4d97f9016ab9ac04acc55d81f0c26f)

Comment 9 errata-xmlrpc 2021-05-18 13:28:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (gcc bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1571


Note You need to log in before you can comment on or make changes to this bug.