Bug 1876901 - Review Request: python-aiosasl - Protocol agnostic SASL Python library
Summary: Review Request: python-aiosasl - Protocol agnostic SASL Python library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-08 13:17 UTC by Fabian Affolter
Modified: 2020-09-29 01:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-09-23 17:11:50 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-08 13:17:19 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiosasl.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiosasl-0.4.1-1.fc32.src.rpm

Project URL: https://github.com/horazont/aiosasl

Description:
aiosasl, pure Python generic asyncio SASL library aiosasl provides a generic,
asyncio-based SASL library. It can be used with any protocol, provided the
neccessary interface code is provided by the application or protocol
implementation.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=50999686

rpmlint output:
$ rpmlint python-aiosasl-0.4.1-1.fc32.src.rpm 
python-aiosasl.src: W: spelling-error %description -l en_US asyncio -> syncopation
python-aiosasl.src: W: spelling-error %description -l en_US neccessary -> necessary, necessarily
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint python3-aiosasl-0.4.1-1.fc32.noarch.rpm 
python3-aiosasl.noarch: W: spelling-error %description -l en_US asyncio -> syncopation
python3-aiosasl.noarch: W: spelling-error %description -l en_US neccessary -> necessary, necessarily
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-09-10 19:26:41 UTC
 - One test fails:

collecting ... collected 72 items / 1 error / 71 selected
==================================== ERRORS ====================================
____________ ERROR collecting tests/test_channel_binding_methods.py ____________
ImportError while importing test module '/builddir/build/BUILD/aiosasl-0.4.1/tests/test_channel_binding_methods.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_channel_binding_methods.py:26: in <module>
    import OpenSSL
E   ModuleNotFoundError: No module named 'OpenSSL'


 - it needs an OpenSSL thingie:

BuildRequires:  python3dist(pyopenssl)

 - Fix this typo:

python3-aiosasl.noarch: W: spelling-error %description -l en_US neccessary -> necessary, necessarily


Then:

 - Latest version packaged
 - License ok
 - Builds in mock
 - Tests pass
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issues before import.

Comment 2 Fabian Affolter 2020-09-11 06:29:19 UTC
Thanks for the feedback.

Comment 3 Gwyn Ciesla 2020-09-11 14:41:14 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiosasl

Comment 4 Fedora Update System 2020-09-14 09:50:21 UTC
FEDORA-2020-1e71ec0e4a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1e71ec0e4a

Comment 5 Fedora Update System 2020-09-14 09:56:41 UTC
FEDORA-2020-882522ee4a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-882522ee4a

Comment 6 Fedora Update System 2020-09-14 10:10:21 UTC
FEDORA-2020-8df3c49fc8 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8df3c49fc8

Comment 7 Fedora Update System 2020-09-14 10:20:29 UTC
FEDORA-EPEL-2020-1f361751d5 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1f361751d5

Comment 8 Fedora Update System 2020-09-14 13:29:31 UTC
FEDORA-2020-882522ee4a has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-882522ee4a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-882522ee4a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-09-14 13:40:44 UTC
FEDORA-EPEL-2020-1f361751d5 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1f361751d5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-09-14 14:09:55 UTC
FEDORA-2020-8df3c49fc8 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8df3c49fc8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8df3c49fc8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-09-14 15:11:24 UTC
FEDORA-2020-1e71ec0e4a has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-1e71ec0e4a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1e71ec0e4a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-09-23 17:11:50 UTC
FEDORA-2020-882522ee4a has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-09-23 18:10:15 UTC
FEDORA-2020-8df3c49fc8 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-09-25 16:57:18 UTC
FEDORA-2020-1e71ec0e4a has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2020-09-29 01:33:49 UTC
FEDORA-EPEL-2020-1f361751d5 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.