Spec URL: https://raphgro.fedorapeople.org/review/py/mock-ssh/python-mock-ssh-server.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/mock-ssh/python-mock-ssh-server-0.8.2-1.el7.src.rpm Description: An SSH server for testing purposes mocksshserver packs a Python context\ manager that implements an SSH server for testing purposes. It is built\ on top of paramiko, so it does not need OpenSSH binaries to be installed. Fedora Account System Username: raphgro Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=51041923 Note: paramiko isn't added as a dependency for a build in epel7 but properly in rawhide, still investigating.
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/fab/Documents/repos/reviews/1877240-python-mock-ssh-server/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - "Source0:" could be replaced with something like "%{url}/archive/%{version}/%{srcname}-%{version}.tar.gz" - Add a trailing / to "%{python3_sitelib}/mockssh" to indicate that it's a directory - Replace "...-py?.?.egg-info" with "...-py%{python3_version}.egg-info/" to allow the package to build with Python > 3.9 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/fab/Documents/repos/reviews/1877240-python-mock-ssh- server/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/fab/Documents/repos/reviews/1877240-python-mock-ssh-server/srpm- unpacked/python-mock-ssh-server.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-mock-ssh-server-0.8.2-1.fc34.noarch.rpm python-mock-ssh-server-0.8.2-1.fc34.src.rpm python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US mocksshserver -> CompuServe python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US paramiko -> paramour python-mock-ssh-server.src: W: spelling-error %description -l en_US mocksshserver -> CompuServe python-mock-ssh-server.src: W: spelling-error %description -l en_US paramiko -> paramour 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name python3-mock-ssh-server 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/carletes/mock-ssh-server/archive/0.8.2.tar.gz#/mock-ssh-server-0.8.2.tar.gz : CHECKSUM(SHA256) this package : ce778d5366164e40c81b8f2ac607dfe9708a36c3612c7a21b6fddda803e86276 CHECKSUM(SHA256) upstream package : b39c006eb3b0b2370623e7acf93e5938a7a7c3e119b5a4f9a3dfcc2de88b34d2 diff -r also reports differences Requires -------- python3-mock-ssh-server (rpmlib, GLIBC filtered): python(abi) python3-paramiko python3.9dist(paramiko) Provides -------- python3-mock-ssh-server: python-mock-ssh-server python3-mock-ssh-server python3.9-mock-ssh-server python3.9dist(mock-ssh-server) python3dist(mock-ssh-server) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1877240 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Perl, Haskell, C/C++, R, fonts, Ocaml, PHP, Java, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Hi Fabian, thanks for your interest. Fixed your hints and reuploaded, links are the same.
There is still a checksum mismatch. SRPM $ sha256sum mock-ssh-server-0.8.2.tar.gz ce778d5366164e40c81b8f2ac607dfe9708a36c3612c7a21b6fddda803e86276 mock-ssh-server-0.8.2.tar.gz Upstream: $ sha256sum mock-ssh-server-0.8.2.tar.gz b39c006eb3b0b2370623e7acf93e5938a7a7c3e119b5a4f9a3dfcc2de88b34d2 mock-ssh-server-0.8.2.tar.gz You have to pull the source again and rebuild the package. Please consider to make those changes as well and bump the release. - Add a trailing / to "%{python3_sitelib}/mockssh" to indicate that it's a directory - Replace "...-py?.?.egg-info" with "...-py%{python3_version}.egg-info/" to allow the package to build with Python > 3.9
Sorry, forgot the reupload (my bad!). Please try again.
It's still 0.8.2-1. Every updates should add a changelog entry for traceability.
OK, as you wish … Spec URL: https://raphgro.fedorapeople.org/review/py/mock-ssh/python-mock-ssh-server.spec SRPM URL: https://raphgro.fedorapeople.org/review/py/mock-ssh/python-mock-ssh-server-0.8.2-2.el7.src.rpm Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=56713220
ping
It seems all the issues found in review were fixed. Fabian, please approve!
As discussed with tibbs on #fedora-devel earlier today, this can be treated as stalled reviewer, thus I'm finishing this hereby. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 16 files have unknown license. Detailed output of licensecheck in /home/robert/1877240-python-mock-ssh- server/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-mock-ssh-server-0.8.2-2.fc35.noarch.rpm python-mock-ssh-server-0.8.2-2.fc35.src.rpm python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US mocksshserver -> CompuServe python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US paramiko -> paramour python-mock-ssh-server.src: W: spelling-error %description -l en_US mocksshserver -> CompuServe python-mock-ssh-server.src: W: spelling-error %description -l en_US paramiko -> paramour 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US mocksshserver -> CompuServe python3-mock-ssh-server.noarch: W: spelling-error %description -l en_US paramiko -> paramour 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/carletes/mock-ssh-server/archive/0.8.2/mock-ssh-server-0.8.2.tar.gz : CHECKSUM(SHA256) this package : b39c006eb3b0b2370623e7acf93e5938a7a7c3e119b5a4f9a3dfcc2de88b34d2 CHECKSUM(SHA256) upstream package : b39c006eb3b0b2370623e7acf93e5938a7a7c3e119b5a4f9a3dfcc2de88b34d2 Requires -------- python3-mock-ssh-server (rpmlib, GLIBC filtered): python(abi) python3-paramiko python3.9dist(paramiko) Provides -------- python3-mock-ssh-server: python-mock-ssh-server python3-mock-ssh-server python3.9-mock-ssh-server python3.9dist(mock-ssh-server) python3dist(mock-ssh-server) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1877240 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, R, SugarActivity, fonts, Java, Haskell, Ocaml, Perl, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Additionally, the issues mentioned by Fabian in comment #1 have been solved, too -> APPROVED
> … thus I'm finishing this hereby. Thanks. rawhide requested https://pagure.io/releng/fedora-scm-requests/issue/32524 Additional branches could follow.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mock-ssh-server
Package imported to rawhide.