Bug 1877691 - Review Request: python-cbor2 - Python CBOR (de)serializer with extensive tag support
Summary: Review Request: python-cbor2 - Python CBOR (de)serializer with extensive tag ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-10 08:09 UTC by Fabian Affolter
Modified: 2020-09-25 16:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-09-25 16:58:14 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-10 08:09:29 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-cbor2.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-cbor2-5.1.2-1.fc32.src.rpm

Project URL: https://github.com/agronholm/cbor2

Description:
This library provides encoding and decoding for the Concise Binary Object
Representation (CBOR) (RFC 7049) serialization format.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=51118260

rpmlint output:
$ rpmlint python-cbor2-5.1.2-1.fc32.src.rpm 
python-cbor2.src: W: spelling-error Summary(en_US) de -> DE, ed, d
python-cbor2.src: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint python3-cbor2-5.1.2-1.fc32.x86_64.rpm
python3-cbor2.x86_64: W: spelling-error Summary(en_US) de -> DE, ed, d
python3-cbor2.x86_64: W: spelling-error Summary(en_US) serializer -> serialize, serializes, serialized
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-09-10 20:18:46 UTC
+ PYTHONPATH=/builddir/build/BUILD/cbor2-5.1.2
+ sphinx-build-3 docs html
Running Sphinx v3.2.1
making output directory... done
WARNING: html_static_path entry '_static' does not exist
Theme error:
sphinx_rtd_theme is no longer a hard dependency since version 1.4.0. Please install it manually.(pip install sphinx_rtd_theme)
error: Bad exit status from /var/tmp/rpm-tmp.5xGoex (%install)
    Bad exit status from /var/tmp/rpm-tmp.5xGoex (%install)

 Add:

BuildRequires:  python3dist(sphinx-rtd-theme)

 - This should be noarch:

%package -n python-%{pypi_name}-doc
Summary:        cbor2 documentation
BuildArch:      noarch
%description -n python-%{pypi_name}-doc
Documentation for cbor2.


Then:

 - Latest version packaged
 - License ok
 - Builds in mock
 - Tests pass
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issues before import.

Comment 2 Fabian Affolter 2020-09-11 06:43:41 UTC
Thanks for the feedback.

Comment 3 Gwyn Ciesla 2020-09-14 19:18:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cbor2

Comment 4 Fedora Update System 2020-09-14 20:10:10 UTC
FEDORA-2020-22b829a09d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-22b829a09d

Comment 5 Fedora Update System 2020-09-15 14:53:37 UTC
FEDORA-2020-22b829a09d has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-22b829a09d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-22b829a09d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-09-25 16:58:14 UTC
FEDORA-2020-22b829a09d has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.