Bug 1877699

Description of problem:

podman does not use $TMPDIR loading an tar file.
Podman load command fail on systems with small /var/tmp partition.



Version-Release number of selected component (if applicable):
podman-1.6.4-18.el7_8.x86_64 (latest version in RHEL7)


How reproducible:
100%

Steps to Reproduce:
1. Set /var/tmp small small size.
   # mount -t tmpfs -o size=1M tmpfs /var/tmp
2. Set environment variable to /tmp.
   # export TMPDIR=/tmp
3. Execute podman load command.

# podman load -i ./redhat.tar
Getting image source signatures
Copying blob 22415211085f skipped: already exists  
Copying blob 063d4ba31922 skipped: already exists  
Copying blob 0a0f017f8754 [======>-------------------------------] 92.3MiB / 523.1MiB
  write /var/tmp/storage071747019/1: no space left on device
Error: error pulling "": unable to pull dir:./redhat.tar: error determining pull goal for image "dir:./redhat.tar": error parsing dest reference name "localhost/./redhat.tar": error parsing named reference "localhost/./redhat.tar": invalid reference format


Actual results:
podman load command use /var/tmp directory.

Expected results:
podman load command use /tmp directory.

Additional info:

I think, following patch fix the issue.

  https://github.com/containers/podman/pull/5412


3 cmd/podman/load.go
@@ -10,6 +10,7 @@ import (
	"github.com/containers/libpod/cmd/podman/cliconfig"
	"github.com/containers/libpod/cmd/podman/shared/parse"
	"github.com/containers/libpod/pkg/adapter"
	"github.com/containers/libpod/pkg/util"
	"github.com/pkg/errors"
	"github.com/spf13/cobra"
	"golang.org/x/crypto/ssh/terminal"
@@ -75,7 +76,7 @@ func loadCmd(c *cliconfig.LoadValues) error {
		if terminal.IsTerminal(int(os.Stdin.Fd())) {
			return errors.Errorf("cannot read from terminal. Use command-line redirection or the --input flag.")
		}
		outFile, err := ioutil.TempFile("/var/tmp", "podman")     <==
		outFile, err := ioutil.TempFile(util.Tmpdir(), "podman")
		if err != nil {
			return errors.Errorf("error creating file %v", err)
		}


This patch is not yet backported to our podman.
podman/load.go in podman-1.6.4-18.el7_8.src.rpm
///
     75                 if terminal.IsTerminal(int(os.Stdin.Fd())) {
     76                         return errors.Errorf("cannot read from terminal. Use command-line redirection or the --input flag        .")
     77                 }
     78                 outFile, err := ioutil.TempFile("/var/tmp", "podman")              <==
     79                 if err != nil {
     80                         return errors.Errorf("error creating file %v", err)
     81                 }
     82                 defer os.Remove(outFile.Name())
     83                 defer outFile.Close()
     84 
     85                 _, err = io.Copy(outFile, os.Stdin)
     86                 if err != nil {
     87                         return errors.Errorf("error copying file %v", err)
     88                 }
     89 
     90                 c.Input = outFile.Name()
     91         }

Could you backport the patch to our podman?


The issue looks like following bugzilla for rhel8.
https://bugzilla.redhat.com/show_bug.cgi?id=1769918

Thanks
Hayato Suzuki