Bug 1878143 - Review Request: python-uptime - Cross-platform uptime library
Summary: Review Request: python-uptime - Cross-platform uptime library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andy Mender
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-11 13:12 UTC by Fabian Affolter
Modified: 2020-10-01 01:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-23 17:12:05 UTC
Type: ---
Embargoed:
andymenderunix: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-09-11 13:12:59 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-uptime.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-uptime-3.0.1-1.fc32.src.rpm

Project URL: https://github.com/Cairnarvon/uptime

Description:
This module provides a cross-platform way to retrieve system uptime and boot
time.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=51216391

rpmlint output:
$ rpmlint python-uptime-3.0.1-1.fc32.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python3-uptime-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

Comment 1 Andy Mender 2020-09-13 12:41:02 UTC
There is a bit of a chicken and egg problem with python-uptime and tests. The project itself provides tests so it's possible to add a %check phase to the SPEC file to enable testing. However, the project doesn't use GitHub release tarballs and versioning is limited to PyPi (via setup.py). We can ask upstream whether it would be okay for them to start generating git release tags as part of their PyPi-centric version-bumping routine. 
What do you think?

Regardless, everything looks in order so package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     Review: not quite sure what fedora-review means here. There is a SO file
     inside %{python3_sitearch}/%{pypi_name}/ called _posix.cpython-39-x86_64-linux-gnu.so, 
     but it's an internal module for python-uptime.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 2-clause "Simplified" License", "Unknown or generated". 6
     files have unknown license. Detailed output of licensecheck in
     /home/amender/rpmbuild/SPECS/python-uptime/python-
     uptime/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-uptime
     Review: not needed in this case.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
     Review: mentioned in an earlier comment.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: python3-uptime-3.0.1-1.fc34.x86_64.rpm
          python-uptime-debugsource-3.0.1-1.fc34.x86_64.rpm
          python-uptime-3.0.1-1.fc32.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
(none): E: no installed packages by name python3-uptime
(none): E: no installed packages by name python-uptime-debugsource
0 packages and 0 specfiles checked; 0 errors, 0 warnings.



Unversioned so-files
--------------------
python3-uptime: /usr/lib64/python3.9/site-packages/uptime/_posix.cpython-39-x86_64-linux-gnu.so

Source checksums
----------------
https://files.pythonhosted.org/packages/source/u/uptime/uptime-3.0.1.tar.gz :
  CHECKSUM(SHA256) this package     : 7c300254775b807ce46e3dcbcda30aa3b9a204b9c57a7ac1e79ee6dbe3942973
  CHECKSUM(SHA256) upstream package : 7c300254775b807ce46e3dcbcda30aa3b9a204b9c57a7ac1e79ee6dbe3942973


Requires
--------
python3-uptime (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    python(abi)
    rtld(GNU_HASH)

python-uptime-debugsource (rpmlib, GLIBC filtered):



Provides
--------
python3-uptime:
    python-uptime
    python3-uptime
    python3-uptime(x86-64)
    python3.9-uptime
    python3.9dist(uptime)
    python3dist(uptime)

python-uptime-debugsource:
    python-uptime-debugsource
    python-uptime-debugsource(x86-64)

Comment 2 Fabian Affolter 2020-09-15 13:30:53 UTC
(In reply to Andy Mender from comment #1)
> There is a bit of a chicken and egg problem with python-uptime and tests.
> The project itself provides tests so it's possible to add a %check phase to
> the SPEC file to enable testing. However, the project doesn't use GitHub
> release tarballs and versioning is limited to PyPi (via setup.py). We can
> ask upstream whether it would be okay for them to start generating git
> release tags as part of their PyPi-centric version-bumping routine. 
> What do you think?

I opened an issue about the missing tests and I will talk to the developer of the package that depends on python-uptime if he is willing to move to a different module. python-uptime looks a little dead. The problem is that there are not much alternatives.

Anyways, thanks for the review.

Comment 3 Gwyn Ciesla 2020-09-15 13:45:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-uptime

Comment 4 Fedora Update System 2020-09-15 15:25:59 UTC
FEDORA-2020-3d0d98d39d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3d0d98d39d

Comment 5 Fedora Update System 2020-09-15 15:31:36 UTC
FEDORA-2020-5cbb79fe31 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5cbb79fe31

Comment 6 Fedora Update System 2020-09-15 15:38:50 UTC
FEDORA-2020-d5d438bef9 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d5d438bef9

Comment 7 Fedora Update System 2020-09-15 15:46:47 UTC
FEDORA-EPEL-2020-a84bbc290a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-a84bbc290a

Comment 8 Andy Mender 2020-09-15 19:26:05 UTC
> I opened an issue about the missing tests and I will talk to the developer of the package that depends on python-uptime if he is willing to move to a different module. python-uptime looks a little dead. The problem is that there are not much alternatives.
> 
> Anyways, thanks for the review.

Thanks for the heads-up and you're welcome! :)

Comment 9 Fedora Update System 2020-09-16 14:30:03 UTC
FEDORA-2020-5cbb79fe31 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5cbb79fe31 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5cbb79fe31

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-09-16 14:58:26 UTC
FEDORA-EPEL-2020-a84bbc290a has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-a84bbc290a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-09-16 15:35:58 UTC
FEDORA-2020-d5d438bef9 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d5d438bef9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d5d438bef9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-09-16 18:56:57 UTC
FEDORA-2020-3d0d98d39d has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-3d0d98d39d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3d0d98d39d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2020-09-23 17:12:05 UTC
FEDORA-2020-5cbb79fe31 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-09-23 18:10:24 UTC
FEDORA-2020-d5d438bef9 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2020-09-25 16:58:55 UTC
FEDORA-2020-3d0d98d39d has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2020-10-01 01:41:53 UTC
FEDORA-EPEL-2020-a84bbc290a has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.