Spec URL: https://gombosg.fedorapeople.org/antimicrox/antimicrox.spec SRPM URL: https://gombosg.fedorapeople.org/antimicrox/antimicrox-3.1-1.20200911git9b383.fc32.src.rpm Description: antimicrox is a graphical program used to map keyboard keys and mouse controls to a gamepad. This program is useful for playing PC games using a gamepad that do not have any form of built-in gamepad support. antimicrox is a fork of AntiMicro which was inspired by QJoyPad but has additional features. Fedora Account System Username: gombosg ---- Old maintainer stepped down at https://github.com/juliagoda/antimicroX. We took over at https://github.com/AntiMicroX/antimicrox. - Renamed from 'antimicroX' to 'antimicrox' so that the binary and package name are all lowercase. - Changed repo name from previous one. - Changed appstream ID to io.github.antimicrox.antimicrox to facilitate Flathub submission - Obsoletes the old package antimicroX, provides and upgrade path. No new versions of the old package will be released. No other notable changes in specfile. After submission, old antimicroX (https://src.fedoraproject.org/rpms/antimicroX) package will be retired.
With regard to the build failures on arm, I'm not sure if it were preferable to change component in RHBZ#1849216 or file a new one. Do what seems more reasonable to you. The package is approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in antimicrox-libantilib , antimicrox-libantilib-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: antimicrox-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-libantilib-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-libantilib-devel-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-debuginfo-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-debugsource-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-3.1-1.20200911git9b383.fc34.src.rpm antimicrox.x86_64: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicrox.x86_64: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed antimicrox-libantilib.x86_64: W: summary-not-capitalized C antimicrox libraries antimicrox-libantilib.x86_64: W: no-documentation antimicrox-libantilib-devel.x86_64: W: no-documentation antimicrox.src: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicrox.src: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed 6 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: antimicrox-debuginfo-3.1-1.20200911git9b383.fc34.x86_64.rpm antimicrox-libantilib-debuginfo-3.1-1.20200911git9b383.fc34.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- antimicrox.x86_64: W: spelling-error Summary(en_US) gamepad -> game pad, game-pad, gamed antimicrox.x86_64: W: spelling-error %description -l en_US gamepad -> game pad, game-pad, gamed antimicrox-libantilib-devel.x86_64: W: no-documentation antimicrox-libantilib.x86_64: W: summary-not-capitalized C antimicrox libraries antimicrox-libantilib.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://github.com/AntiMicroX/antimicrox/archive/9b383805b7967884a8b602c5a43be415c3427fe4/antimicrox-9b383805b7967884a8b602c5a43be415c3427fe4.tar.gz : CHECKSUM(SHA256) this package : d1e7586fd7ada455213492856411b7d1705e856b1085c49b8e827b7432610a1b CHECKSUM(SHA256) upstream package : d1e7586fd7ada455213492856411b7d1705e856b1085c49b8e827b7432610a1b Requires -------- antimicrox (rpmlib, GLIBC filtered): antimicrox-libantilib(x86-64) hicolor-icon-theme libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libantilib.so.1()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) shared-mime-info antimicrox-libantilib (rpmlib, GLIBC filtered): libQt5Concurrent.so.5()(64bit) libQt5Concurrent.so.5(Qt_5)(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libSDL2-2.0.so.0()(64bit) libX11.so.6()(64bit) libXi.so.6()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) antimicrox-libantilib-devel (rpmlib, GLIBC filtered): antimicrox-libantilib(x86-64) libantilib.so.1()(64bit) antimicrox-debuginfo (rpmlib, GLIBC filtered): antimicrox-debugsource (rpmlib, GLIBC filtered): Provides -------- antimicrox: antimicroX antimicrox antimicrox(x86-64) application() application(io.github.antimicrox.antimicrox.desktop) metainfo() metainfo(io.github.antimicrox.antimicrox.appdata.xml) mimehandler(application/x-amgp) antimicrox-libantilib: antimicroX-libantilib antimicrox-libantilib antimicrox-libantilib(x86-64) libantilib.so.1()(64bit) antimicrox-libantilib-devel: antimicroX-libantilib-devel antimicrox-libantilib-devel antimicrox-libantilib-devel(x86-64) antimicrox-debuginfo: antimicrox-debuginfo antimicrox-debuginfo(x86-64) debuginfo(build-id) antimicrox-debugsource: antimicrox-debugsource antimicrox-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1878279 -v Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, PHP, Haskell, SugarActivity, Python, Java, Ocaml, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/antimicrox
FEDORA-2020-4be3f9a561 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-4be3f9a561
FEDORA-2020-23845d9c7c has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-23845d9c7c
FEDORA-2020-f35337829c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f35337829c
FEDORA-2020-f35337829c has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f35337829c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f35337829c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-4be3f9a561 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-4be3f9a561 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-4be3f9a561 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-23845d9c7c has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-23845d9c7c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-23845d9c7c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-23845d9c7c has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-4be3f9a561 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-f35337829c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.