Bug 1878488 - Review Request: perl-String-TtyLength - Length or width of string excluding ANSI tty codes
Summary: Review Request: perl-String-TtyLength - Length or width of string excluding A...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1876823
TreeView+ depends on / blocked
 
Reported: 2020-09-13 11:56 UTC by Emmanuel Seyman
Modified: 2020-09-14 20:47 UTC (History)
2 users (show)

Fixed In Version: perl-String-TtyLength-0.02-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-14 20:47:47 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2020-09-13 11:56:03 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-String-TtyLength/perl-String-TtyLength.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-String-TtyLength/perl-String-TtyLength-0.02-1.fc32.src.rpm
Description:
This module provides two functions which tell you the length and width
of a string as it will appear on a terminal (tty), excluding any ANSI
escape codes.

Fedora Account System Username: eseyman
Rpmlint Output:
perl-String-TtyLength.src: W: spelling-error Summary(en_US) tty -> try, ttys, atty
perl-String-TtyLength.src: W: spelling-error %description -l en_US tty -> try, ttys, atty
perl-String-TtyLength.noarch: W: spelling-error Summary(en_US) tty -> try, ttys, atty
perl-String-TtyLength.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Comment 1 Jitka Plesnikova 2020-09-14 08:49:40 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-String-TtyLength-0.02-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(parent)
      1 perl(strict)
      1 perl(Unicode::EastAsianWidth) >= 12.0
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-String-TtyLength-0.02-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(String::TtyLength) = 0.02
      1 perl-String-TtyLength = 0.02-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-String-TtyLength*
perl-String-TtyLength.noarch: W: spelling-error Summary(en_US) tty -> try, ttys, atty
perl-String-TtyLength.noarch: W: spelling-error %description -l en_US tty -> try, ttys, atty
perl-String-TtyLength.src: W: spelling-error Summary(en_US) tty -> try, ttys, atty
perl-String-TtyLength.src: W: spelling-error %description -l en_US tty -> try, ttys, atty
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 2 Emmanuel Seyman 2020-09-14 19:40:17 UTC
Thank you for the review, Jikta.
I've requested a repo for this package (https://pagure.io/releng/fedora-scm-requests/issue/29059)

Comment 3 Gwyn Ciesla 2020-09-14 19:49:59 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-String-TtyLength

Comment 4 Emmanuel Seyman 2020-09-14 20:47:47 UTC
Package built for F34:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1610664


Note You need to log in before you can comment on or make changes to this bug.