Spec URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SPECS/catimg.spec SRPM URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/tree/SRPMS/catimg-2.7.0-1.fc32.src.rpm Description: catimg is a little program written in C with no dependencies that prints images in terminal. It supports JPEG, PNG, ICO and GIF formats. Fedora Account System Username: keesdejong
Fixed the URL for the SRPM. Spec URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SPECS/catimg.spec SRPM URL: https://fedorapeople.org/cgit/keesdejong/public_git/rpmbuild.git/plain/SRPMS/catimg-2.7.0-1.fc32.src.rpm Description: catimg is a little program written in C with no dependencies that prints images in terminal. It supports JPEG, PNG, ICO and GIF formats. Fedora Account System Username: keesdejong
Strange... My mock build works fine: https://koji.fedoraproject.org/koji/taskinfo?taskID=51376359 However, when I do `fedora-review -b 1878514` to review the package, it fails with: Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.BJOdJw + umask 022 + cd /builddir/build/BUILD + '[' /builddir/build/BUILDROOT/catimg-2.7.0-1.fc34.x86_64 '!=' / ']' + rm -rf /builddir/build/BUILDROOT/catimg-2.7.0-1.fc34.x86_64 ++ dirname /builddir/build/BUILDROOT/catimg-2.7.0-1.fc34.x86_64 + mkdir -p /builddir/build/BUILDROOT + mkdir /builddir/build/BUILDROOT/catimg-2.7.0-1.fc34.x86_64 + cd catimg-2.7.0 + /usr/bin/make install DESTDIR=/builddir/build/BUILDROOT/catimg-2.7.0-1.fc34.x86_64 'INSTALL=/usr/bin/install -p' make: *** No rule to make target 'install'. Stop. RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.BJOdJw (%install) Bad exit status from /var/tmp/rpm-tmp.BJOdJw (%install) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/mockbuild/trace_decorator.py", line 93, in trace result = func(*args, **kw) File "/usr/lib/python3.8/site-packages/mockbuild/util.py", line 776, in do_with_status raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode) mockbuild.exception.Error: Command failed: # /usr/bin/systemd-nspawn -q -M cad744f303f7446896cee40ee35c03e3 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.husl3a1r:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/loop-control --bind=/dev/loop0 -- bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/ builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/ SPECS/catimg.spec Mock Version: 2.5 I tried adding `%make_install -C %{_target_platform}`, since the orphaned package had this as well. But then my mock build fails. Any suggestions?
You did a koji scratch build for F32, whereas the fedora-review mock build is for F34. Some time ago CMake SRPM macros were modified so that out-of-source builds are now the default. >%build >%cmake . > >%install >%make_install Try changing this part to: %build %cmake . %cmake_build %install %cmake_install Also, >URL: https://github.com/posva/catimg >Source0: https://codeload.github.com/posva/%{name}/tar.gz/%{version}#/%{name}-%{version}.tar.gz You can use "%{URL}/archive/%{version}/%{name}-%{version}.tar.gz" here for a cleaner Source URL.
(In reply to Artur Frenszek-Iwicki from comment #3) Thanks! That indeed solved it. --- I completed my fedora-review. I think the only critical item on the list is the one about "Package does not own files or directories owned by other packages". That doesn't seem right. But at the other hand, if I don't explicitly own them, I also get an error. What's the best course of action? According to this link and examples, I did it correctly: https://rpm-packaging-guide.github.io/#working-with-spec-files "The %files section is where we provide the list of files that this RPM provides and where it’s intended for them to live on the system that the RPM is installed upon. Note here that this isn’t relative to the %{buildroot} but the full path for the files as they are expected to exist on the end system after installation. Therefore, the listing for the pello file we are installing will be %{_bindir}/pello. We will also need to provide a %dir listing to define that this package “owns” the library directory we created as well as all the files we placed in it." Can someone confirm? This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/catimg See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 23 files have unknown license. Detailed output of licensecheck in /home/kjong/git/rpmbuild/1878514-catimg/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/zsh(creds, skim, swaylock, pdfgrep, ninja-build, zola, ripgrep, zsh, mercurial-py3, stratis-cli, exercism, sway, mercurial-py2, vcsh, curl, exa, xss-lock, why3, snapd, ffsend, etckeeper, pulseaudio, fd-find, cpu-x, gpaste, mako, git-delta, fedmod, caddy, polybar, python3-wstool, task, wlogout, docker-compose, awscli, hyperfine, libinput, osmium-tool, reprepro, swayidle, kde-connect), /usr/share/zsh/site-functions(creds, skim, swaylock, pdfgrep, ninja-build, zola, ripgrep, zsh, mercurial- py3, stratis-cli, podman, exercism, imgp, sway, mercurial-py2, vcsh, curl, exa, xss-lock, ddgr, why3, snapd, ffsend, arch-install-scripts, pulseaudio, fd-find, kompose, firewalld, cpu-x, gpaste, mako, git- delta, python3-wstool, googler, caddy, polybar, task, wlogout, lastpass-cli, docker-compose, xpanes, awscli, hyperfine, libinput, osmium-tool, reprepro, nnn, swayidle, fzf, khard, flatpak, restic, kde-connect, buku) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: catimg-2.7.0-1.fc34.x86_64.rpm catimg-debuginfo-2.7.0-1.fc34.x86_64.rpm catimg-debugsource-2.7.0-1.fc34.x86_64.rpm catimg-2.7.0-1.fc34.src.rpm catimg.src: W: strange-permission catimg-2.7.0.tar.gz 640 catimg.src: W: strange-permission catimg.spec 640 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: catimg-debuginfo-2.7.0-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. catimg.x86_64: W: invalid-url URL: https://github.com/posva/catimg <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. catimg-debuginfo.x86_64: W: invalid-url URL: https://github.com/posva/catimg <urlopen error [Errno -3] Temporary failure in name resolution> warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. catimg-debugsource.x86_64: W: invalid-url URL: https://github.com/posva/catimg <urlopen error [Errno -3] Temporary failure in name resolution> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://github.com/posva/catimg/archive/2.7.0/catimg-2.7.0.tar.gz : CHECKSUM(SHA256) this package : 3a6450316ff62fb07c3facb47ea208bf98f62abd02783e88c56f2a6508035139 CHECKSUM(SHA256) upstream package : 3a6450316ff62fb07c3facb47ea208bf98f62abd02783e88c56f2a6508035139 Requires -------- catimg (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) catimg-debuginfo (rpmlib, GLIBC filtered): catimg-debugsource (rpmlib, GLIBC filtered): Provides -------- catimg: catimg catimg(x86-64) catimg-debuginfo: catimg-debuginfo catimg-debuginfo(x86-64) debuginfo(build-id) catimg-debugsource: catimg-debugsource catimg-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1878514 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, Ocaml, Perl, Python, SugarActivity, Java, R, fonts, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
fedora-review (or rpmlint) is being obtuse here. The correct solution is to own those directories. (As you can see from the error message, about 40 other packages are doing exactly that.)
Can someone review the package and if everything seems alright, approve it? Thanks!
Kees, this review is assigned to Artur, so you have to wait for his answer. (Unless there's no response for a long time. In that case it's fine to look for another reviewer.)
(In reply to Artur Frenszek-Iwicki from comment #3) Hi Artur, Could you please finalize your review? If the package looks alright, then please approve it. Thanks!
Package approved. Sorry for taking so long. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Package owns the zsh tab-completion directory. This is fine. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Note: to koji scratch build linked below. https://koji.fedoraproject.org/koji/taskinfo?taskID=53693603 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: catimg-2.7.0-1.fc34.x86_64.rpm catimg-debuginfo-2.7.0-1.fc34.x86_64.rpm catimg-debugsource-2.7.0-1.fc34.x86_64.rpm catimg-2.7.0-1.fc34.src.rpm catimg.src: W: strange-permission catimg-2.7.0.tar.gz 640 catimg.src: W: strange-permission catimg.spec 640 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: catimg-debuginfo-2.7.0-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name catimg-debuginfo (none): E: no installed packages by name catimg-debugsource (none): E: no installed packages by name catimg 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/posva/catimg/archive/2.7.0/catimg-2.7.0.tar.gz : CHECKSUM(SHA256) this package : 3a6450316ff62fb07c3facb47ea208bf98f62abd02783e88c56f2a6508035139 CHECKSUM(SHA256) upstream package : 3a6450316ff62fb07c3facb47ea208bf98f62abd02783e88c56f2a6508035139 Requires -------- catimg (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) catimg-debuginfo (rpmlib, GLIBC filtered): catimg-debugsource (rpmlib, GLIBC filtered): Provides -------- catimg: catimg catimg(x86-64) catimg-debuginfo: catimg-debuginfo catimg-debuginfo(x86-64) debuginfo(build-id) catimg-debugsource: catimg-debugsource catimg-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review --bug 1878514 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, Python, Perl, Java, R, Haskell, fonts, SugarActivity, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
FEDORA-2020-8fc555fe14 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fc555fe14
FEDORA-2020-f7e4033b8e has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f7e4033b8e
FEDORA-2020-f7e4033b8e has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f7e4033b8e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f7e4033b8e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-8fc555fe14 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-8fc555fe14` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fc555fe14 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-168e4d6426 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-168e4d6426
FEDORA-2020-168e4d6426 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-168e4d6426` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-168e4d6426 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-8fc555fe14 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-f7e4033b8e has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-168e4d6426 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.