Spec URL: https://pagure.io/emacs-async/raw/master/f/emacs-async.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/tuliom/emacs/srpm-builds/01659385/emacs-async-1.9.4-0.fc31.src.rpm Description: Async is an Emacs module that provides asynchronous processing. It's a dependency of other modules, e.g. magit/with-editor. Fedora Account System Username: tuliom I have a successful build available on copr: https://copr.fedorainfracloud.org/coprs/tuliom/emacs/build/1659385/
[!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Try to ask upstream for a separate license file. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define pkg async Use %global instead of %define here. - Patch these obsolete FSF address with the latest one and send it upstream emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async-bytecomp.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async-test.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/dired-async.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/smtpmail-async.el Package approved, please fix the aforementioned issue before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License v3.0 or later", "Unknown or generated", "GNU General Public License v2.0 or later". 2 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/emacs-async/review-emacs- async/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define pkg async [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: emacs-async-1.9.4-0.fc34.noarch.rpm emacs-async-1.9.4-0.fc34.src.rpm emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async-bytecomp.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async-test.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/async.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/dired-async.el emacs-async.noarch: E: incorrect-fsf-address /usr/share/emacs/site-lisp/async/smtpmail-async.el emacs-async.src: E: specfile-error warning: line 16: Possible unexpanded macro in: Requires: emacs(bin) >= %{_emacs_version} 2 packages and 0 specfiles checked; 6 errors, 0 warnings.
(In reply to Robert-André Mauchin 🐧 from comment #1) > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. A patch has been submitted upstream: https://github.com/jwiegley/emacs-async/pull/133 > Try to ask upstream for a separate license file. > > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define pkg async > > Use %global instead of %define here. Fixed. > - Patch these obsolete FSF address with the latest one and send it upstream > > emacs-async.noarch: E: incorrect-fsf-address > /usr/share/emacs/site-lisp/async/async-bytecomp.el > emacs-async.noarch: E: incorrect-fsf-address > /usr/share/emacs/site-lisp/async/async-test.el > emacs-async.noarch: E: incorrect-fsf-address > /usr/share/emacs/site-lisp/async/async.el > emacs-async.noarch: E: incorrect-fsf-address > /usr/share/emacs/site-lisp/async/dired-async.el > emacs-async.noarch: E: incorrect-fsf-address > /usr/share/emacs/site-lisp/async/smtpmail-async.el Fixed. The new spec file is available here: https://pagure.io/emacs-async/blob/master/f/emacs-async.spec I've also requested the repository. Thank you!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/emacs-async
The first build has just landed in Rawhide. Thanks!