Bug 1878661 - anaconda cannot create partition when sda exists a ext4 filesystem
Summary: anaconda cannot create partition when sda exists a ext4 filesystem
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-14 10:06 UTC by Tao Feng
Modified: 2020-10-12 07:34 UTC (History)
9 users (show)

Fixed In Version: anaconda-33.25.4-1.fc33
Clone Of:
Environment:
Last Closed: 2020-10-03 00:56:13 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
anaconda log (17.32 KB, text/plain)
2020-09-14 10:06 UTC, Tao Feng
no flags Details
syslog (452.73 KB, text/plain)
2020-09-14 10:08 UTC, Tao Feng
no flags Details
storage log (84.21 KB, text/plain)
2020-09-14 10:08 UTC, Tao Feng
no flags Details

Description Tao Feng 2020-09-14 10:06:37 UTC
Created attachment 1714741 [details]
anaconda log

Description of problem:
hello, i was install FC32. I got a problem for anaconda.
When i have a disk which is already has a filesystem(ext4), and then i want to do parition in custom. But anaconda may got some bugs. In Manual Partitioning page, I cannot remove Unknow partiton in sda, and in the bottom left of this page, it prints: 0 storage devices selected. That is wired, i do selected sda.


Version-Release number of selected component (if applicable):


How reproducible:
setup a vm for fc32, and mkfs.ext4 for sda then do custom partitioning.

Steps to Reproduce:
1.ctrl + alt + f2, mkfs.ext4 /dev/sda
2.systemctl restart anaconda
3.ctrl + alt + f6, do custom partitioning

Actual results:
Device removal request failed: device is not in the tree

Expected results:
1. remove successfully
2. create partition successfully

Additional info:

Comment 1 Tao Feng 2020-09-14 10:08:27 UTC
Created attachment 1714742 [details]
syslog

Comment 2 Tao Feng 2020-09-14 10:08:47 UTC
Created attachment 1714743 [details]
storage log

Comment 3 Tao Feng 2020-09-14 11:17:15 UTC
I am pretty sure that FC30 is OK

Comment 4 Vladimír Slávik 2020-09-16 13:30:57 UTC
Confirmed with both current master and f33-devel of anaconda.

Comment 5 Tao Feng 2020-09-27 03:53:13 UTC
Hello, Any plan or method to fix this?

thanks ;)

Comment 6 Xia Qirong 2020-09-29 12:07:50 UTC
This bug has two problems. First, when you remove unkown partition in sda, only the format in sda should be destroyed without removing sda from the device tree, but sda is also destroyed. As a result, sda cannot be found during disk initialization and the error "Device removal request failed: device is not in the tree" is reported. Second, "0 storage devices selected" is printed because the format_type of sda is "ext4" rather than "disklabel", and disk 'sda' is filtered by filter_disks_by_names(partitioned_devices, selected_disks) in /pyanaconda/ui/gui/spokes/custom_storage.py. I have proposed a method to fix the first problem, but there is no good way to solve the second problem temporarily.

PR for issue 1: https://github.com/rhinstaller/anaconda/pull/2872

Comment 7 Xia Qirong 2020-09-29 13:15:22 UTC
I propose a method by giving up filtering selected_disks in /pyanaconda/ui/gui/spokes/custom_storage.py that can fix issue "0 storage devices selected". The method has been tested and is effective. However, I'm looking forward to a better solution.

Comment 8 Vladimír Slávik 2020-10-01 14:35:57 UTC
Xia Quirong, thank you for the pull request, it worked perfectly with no changes, so it is merged :)

Comment 9 Fedora Update System 2020-10-01 16:39:41 UTC
FEDORA-2020-384ff75a01 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-384ff75a01

Comment 10 Fedora Update System 2020-10-01 16:39:56 UTC
FEDORA-2020-384ff75a01 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-384ff75a01

Comment 11 Fedora Update System 2020-10-02 01:46:25 UTC
FEDORA-2020-384ff75a01 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-384ff75a01`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-384ff75a01

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-10-03 00:56:13 UTC
FEDORA-2020-384ff75a01 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Xia Qirong 2020-10-12 07:34:17 UTC
(In reply to Xia Qirong from comment #7)
> I propose a method by giving up filtering selected_disks in
> /pyanaconda/ui/gui/spokes/custom_storage.py that can fix issue "0 storage
> devices selected". The method has been tested and is effective. However, I'm
> looking forward to a better solution.

PR for this issue: https://github.com/rhinstaller/anaconda/pull/2917


Note You need to log in before you can comment on or make changes to this bug.