Bug 1878733 - New package: prometheus-webhook-snmp - Prometheus Alertmanager receiver for SNMP traps
Summary: New package: prometheus-webhook-snmp - Prometheus Alertmanager receiver for S...
Keywords:
Status: POST
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: hguemar
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: 1885839 1889778 1894750 1894752 1894753 1894762 1894764 1894766 1894767
TreeView+ depends on / blocked
 
Reported: 2020-09-14 12:15 UTC by Matthias Runge
Modified: 2020-11-05 01:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
csibbitt: rdo-review+


Attachments (Terms of Use)

Description Matthias Runge 2020-09-14 12:15:54 UTC
Description:
prometheus-webhook-snmp is a Prometheus Alertmanager receiver that
translates incoming notifications into SNMP traps.


SPEC: http://www.matthias-runge.de/fedora/prometheus-webhook-snmp.spec
SRPM: http://www.matthias-runge.de/fedora/prometheus-webhook-snmp-1.5-1.src.rpm

Comment 1 Leif Madsen 2020-09-14 17:20:53 UTC
Just one warning when doing a lint check:

rpmlint prometheus-webhook-snmp.spec 
prometheus-webhook-snmp.spec:51: W: setup-not-quiet
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 2 Leif Madsen 2020-09-14 17:26:25 UTC
Since this is for downstream only, I don't think the component RDO is appropriate here.

Comment 3 Leif Madsen 2020-09-14 17:43:13 UTC
Local functional testing results:

[/] mock --buildsrpm --spec ./SPECS/prometheus-webhook-snmp.spec --sources ./SOURCES/ --root epel-8-x86_64 --resultdir ./SRPMS/
[/] mock --rebuild --root epel-8-x86_64 --resultdir ./RPMS/ ./SRPMS/prometheus-webhook-snmp-1.5-1.src.rpm
[x] podman run -it -v ./RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm:/rpmbuild/RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm ubi8 /bin/bash -c '/bin/dnf install /rpmbuild/RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm'

Updating Subscription Management repositories.
Unable to read consumer identity
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Red Hat Universal Base Image 8 (RPMs) - BaseOS                                                                                         6.9 MB/s | 767 kB     00:00    
Red Hat Universal Base Image 8 (RPMs) - AppStream                                                                                       17 MB/s | 4.0 MB     00:00    
Red Hat Universal Base Image 8 (RPMs) - CodeReady Builder                                                                              175 kB/s |  12 kB     00:00    
Error: 
 Problem: conflicting requests
  - nothing provides python3-cherrypy needed by prometheus-webhook-snmp-1.5-1.noarch
  - nothing provides python3-click needed by prometheus-webhook-snmp-1.5-1.noarch
  - nothing provides python3-prometheus-client needed by prometheus-webhook-snmp-1.5-1.noarch
  - nothing provides python3-pysnmp >= 4.4.1 needed by prometheus-webhook-snmp-1.5-1.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)


(Also tested with centos:8 just to validate, same issue)

podman run -it -v ./RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm:/rpmbuild/RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm centos:8 /bin/bash -c '/bin/dnf install /rpmbuild/RPMS/prometheus-webhook-snmp-1.5-1.noarch.rpm'

Comment 4 Matthias Runge 2020-09-15 05:39:24 UTC
Thank you.

Purpose of this review here is mostly to verify this is free software, the license is correct etc.
We'll have to carry missing dependencies as well. They are included in fedora, so that rebuilding them is no issue.

Comment 6 Chris Sibbitt 2020-10-05 18:24:07 UTC
Results of licensecheck and review:

===== licensecheck.txt =====
Unknown or generated
--------------------
prometheus-webhook-snmp-1.5/.editorconfig
prometheus-webhook-snmp-1.5/.pylintrc
prometheus-webhook-snmp-1.5/CHANGELOG.md
prometheus-webhook-snmp-1.5/LICENSE
prometheus-webhook-snmp-1.5/Makefile
prometheus-webhook-snmp-1.5/PROMETHEUS-ALERT-CEPH-MIB.txt
prometheus-webhook-snmp-1.5/README.md
prometheus-webhook-snmp-1.5/debian/changelog
prometheus-webhook-snmp-1.5/debian/compat
prometheus-webhook-snmp-1.5/debian/control
prometheus-webhook-snmp-1.5/debian/copyright
prometheus-webhook-snmp-1.5/debian/prometheus-webhook-snmp.default
prometheus-webhook-snmp-1.5/debian/prometheus-webhook-snmp.dirs
prometheus-webhook-snmp-1.5/debian/rules
prometheus-webhook-snmp-1.5/debian/source/format
prometheus-webhook-snmp-1.5/prometheus-webhook-snmp
prometheus-webhook-snmp-1.5/prometheus-webhook-snmp.service
prometheus-webhook-snmp-1.5/prometheus-webhook-snmp.spec
prometheus-webhook-snmp-1.5/prometheus_webhook_snmp/utils.py
prometheus-webhook-snmp-1.5/requirements.txt
prometheus-webhook-snmp-1.5/tests/test_misc.py
prometheus-webhook-snmp-1.5/tests/test_server.py
prometheus-webhook-snmp-1.5/tox.ini
===== End of licensecheck.txt =====

prometheus-webhook-snmp-1.5/LICENSE is confirmed to be GPLv3

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the Licensing section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not include license text files separate from upstream.


Note You need to log in before you can comment on or make changes to this bug.