Spec URL: https://sk2.org/fedora/gitlint.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4643/51444643/gitlint-0.13.1-1.fc34.src.rpm Description: gitlint checks git commit messages for style, using validations based on well-known community standards or on checks which have proved useful: maximum title length, trailing whitespace checks, punctuation, tabs, minimum body mength, valid email addresses... Fedora Account System Username: skitt Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=51444643
The spec looks good.
The linter complains about a couple of things [majopela@bluehat Downloads]$ rpmlint gitlint* gitlint.src: W: spelling-error Summary(en_US) linter -> liner, liter, inter gitlint.src: W: spelling-error %description -l en_US whitespace -> white space, white-space, whites pace gitlint.src: W: spelling-error %description -l en_US mength -> length 1 packages and 1 specfiles checked; 0 errors, 3 warnings. I guess the whitespace and mength can be changed, why does it complain about linter?
(In reply to Miguel Angel Ajo from comment #2) > The linter complains about a couple of things > > [majopela@bluehat Downloads]$ rpmlint gitlint* > gitlint.src: W: spelling-error Summary(en_US) linter -> liner, liter, inter I replaced that with “linting tool”, which is fine according to rpmlint. > gitlint.src: W: spelling-error %description -l en_US whitespace -> white > space, white-space, whites pace > gitlint.src: W: spelling-error %description -l en_US mength -> length Fixed, thanks!
another question, BuildRequires: git-core Shouldint this be a Requires/too?, isn't it necessary for running and not for building?
(In reply to Miguel Angel Ajo from comment #4) > another question, BuildRequires: git-core > > > Shouldint this be a Requires/too?, isn't it necessary for running and not > for building? Indeed, the shell/git module is supposed to check for git so it doesn’t end up being required for all sub-commands AFAICT, but in practice that doesn’t work: Traceback (most recent call last): File "/usr/local/bin/gitlint", line 5, in <module> from gitlint.cli import cli File "/usr/local/lib/python3.8/site-packages/gitlint/cli.py", line 20, in <module> from gitlint.git import GitContext, GitContextError, git_version File "/usr/local/lib/python3.8/site-packages/gitlint/git.py", line 4, in <module> from gitlint import shell as sh File "/usr/local/lib/python3.8/site-packages/gitlint/shell.py", line 13, in <module> from sh import git # pylint: disable=unused-import,import-error ImportError: cannot import name 'git' from 'sh' (/usr/local/lib/python3.8/site-packages/sh.py) Fixed in the spec.
Thanks [majopela@bluehat Downloads]$ rpmlint gitlint.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
I need to re-file this with my FAS address.