Bug 1879930 - Annotations shouldn't be removed during object reconciliation
Summary: Annotations shouldn't be removed during object reconciliation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Monitoring
Version: 4.6
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: 4.7.0
Assignee: Pawel Krupa
QA Contact: Junqi Zhao
URL:
Whiteboard:
Depends On:
Blocks: 1887338 1887339
TreeView+ depends on / blocked
 
Reported: 2020-09-17 11:28 UTC by Pawel Krupa
Modified: 2021-02-24 15:19 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 1887338 (view as bug list)
Environment:
Last Closed: 2021-02-24 15:18:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-monitoring-operator pull 942 0 None closed Bug 1879930: Preserve labels and annotations during reconciliation 2021-02-21 11:52:01 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:19:03 UTC

Description Pawel Krupa 2020-09-17 11:28:41 UTC
Description of problem:
Currently, CMO removes annotations from objects which it governs. This is incorrect as annotations can be set by other actors.

Version-Release number of selected component (if applicable):
4.6


How reproducible:
always

Steps to Reproduce:
1. Annotate an object governed by CMO (for example a Service or ClusterRole)
2. Wait ~15m for CMO reconciliation
3. Check if annotations are there

Actual results:
Custom annotation is removed

Expected results:
Annotations should exist

Additional info:
This is a result of investigation from https://bugzilla.redhat.com/show_bug.cgi?id=1863011 and possible remediation was discussed in https://github.com/openshift/cluster-monitoring-operator/pull/932#discussion_r490089300

Comment 3 Junqi Zhao 2020-10-13 07:50:59 UTC
tested with 4.7.0-0.ci-2020-10-12-222453, followed the steps in Comment 0,annotations are remained

Comment 7 errata-xmlrpc 2021-02-24 15:18:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.