Bug 1880266 - Review Request: perl-MojoX-Log-Log4perl - Log::Log4perl logging for Mojo/Mojolicious
Summary: Review Request: perl-MojoX-Log-Log4perl - Log::Log4perl logging for Mojo/Mojo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-09-18 07:00 UTC by Emmanuel Seyman
Modified: 2020-09-18 14:27 UTC (History)
2 users (show)

Fixed In Version: perl-MojoX-Log-Log4perl-0.12-2.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-18 14:27:12 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2020-09-18 07:00:52 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-MojoX-Log-Log4perl-Tiny/perl-MojoX-Log-Log4perl-Tiny.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MojoX-Log-Log4perl-Tiny/perl-MojoX-Log-Log4perl-Tiny-0.01-1.fc30.src.rpm
Description:
MojoX::Log::Log4perl::Tiny allows you to replace default Mojolicious
logging Mojo::Log with your existing Log::Log4perl::Logger instance.

Fedora Account System Username: eseyman
Rpmlint Output: 2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2020-09-18 07:27:06 UTC
URL are invalid.

Comment 3 Jitka Plesnikova 2020-09-18 08:33:11 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MojoX-Log-Log4perl-0.12-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Log::Log4perl)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Mojo::Base)
      1 perl(strict)
      1 perl(warnings)
FIX: Please add run-require
     - perl(Log::Log4perl::Level) - lib/MojoX/Log/Log4perl.pm:129

$ rpm -qp --provides perl-MojoX-Log-Log4perl-0.12-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(MojoX::Log::Log4perl) = 0.12
      1 perl-MojoX-Log-Log4perl = 0.12-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-MojoX-Log-Log4perl*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Resolution:
APPROVED

Comment 4 Emmanuel Seyman 2020-09-18 08:44:45 UTC
(In reply to Jitka Plesnikova from comment #3)
>
> FIX: Please add run-require
>      - perl(Log::Log4perl::Level) - lib/MojoX/Log/Log4perl.pm:129

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-MojoX-Log-Log4perl/perl-MojoX-Log-Log4perl.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MojoX-Log-Log4perl/perl-MojoX-Log-Log4perl-0.12-2.fc32.src.rpm

I've also requested the package repo (https://pagure.io/releng/fedora-scm-requests/issue/29141). Thank you for the review, Jikta.

Comment 5 Gwyn Ciesla 2020-09-18 13:33:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MojoX-Log-Log4perl

Comment 6 Emmanuel Seyman 2020-09-18 14:27:12 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1612896


Note You need to log in before you can comment on or make changes to this bug.