Bug 1880268
| Summary: | [nfp] xdp-loader unload failed after load a sample xdp program | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Zhiqian Guan <zhguan> |
| Component: | xdp-tools | Assignee: | Toke Høiland-Jørgensen <thoiland> |
| Status: | CLOSED ERRATA | QA Contact: | Zhiqian Guan <zhguan> |
| Severity: | unspecified | Docs Contact: | Marc Muehlfeld <mmuehlfe> |
| Priority: | unspecified | ||
| Version: | 8.3 | CC: | thoiland, zhguan |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | 8.4 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | xdp-tools-1.1.0-1.el8.x86_64 | Doc Type: | Bug Fix |
| Doc Text: |
.Unloading XDP programs no longer fails on Netronome network cards that use the `nfp` driver
Previously, the `nfp` driver for Netronome network cards contained a bug. As a consequence, unloading eXpress Data Path (XDP) programs failed if you used such a card and loaded the XDP program using the `IFLA_XDP_EXPECTED_FD` feature with the `XDP_FLAGS_REPLACE` flag. For example, this affected XDP programs that were loaded using the `libxdp` library. This bug has been fixed. As a result, unloading an XDP program from Netronome network cards works as expected.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-05-18 16:09:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1680409 | ||
|
Description
Zhiqian Guan
2020-09-18 07:06:22 UTC
file bug for tracking the unresolved known issue of xdp-tools, details please see: https://bugzilla.redhat.com/show_bug.cgi?id=1820670, comment96, comment97 For this (and the other nfp-related bug), I will likely need access to a machine with an nfp device - Zhiqian, is there a particular qe box I can use for that, and how do I get access to that? :) I'm also sharing the nfp test bed with others, let me check with him first :~) Hi Toke, Is there any plan ddl for this bug? I'm also going to set the ITR to 8.4.0 and need info to set the ITM field:~) (In reply to Zhiqian Guan from comment #5) > Hi Toke, > > Is there any plan ddl for this bug? I'm also going to set the ITR to 8.4.0 > and need info to set the ITM field:~) Hmm, the ITM includes QE verification, right? So I think it's simplest if we do this along with the 5.10 backport, as there are kernel features we'll need in the version of xdp-tools we ship in 8.4, so if we can just do everything at once that would be simpler... So set this to whatever the 5.10 backport ends up as +1 (or 2)? (same for the other xdp-tools issues) (In reply to Toke Høiland-Jørgensen from comment #6) > (In reply to Zhiqian Guan from comment #5) > > Hi Toke, > > > > Is there any plan ddl for this bug? I'm also going to set the ITR to 8.4.0 > > and need info to set the ITM field:~) > > Hmm, the ITM includes QE verification, right? So I think it's simplest if we > do this along with the 5.10 backport, as there are kernel features we'll > need in the version of xdp-tools we ship in 8.4, so if we can just do > everything at once that would be simpler... > > So set this to whatever the 5.10 backport ends up as +1 (or 2)? > > (same for the other xdp-tools issues) OK, got it:) Hi Toke, Since the 5.10 backport development for ebpf/xdp will be done by ITM12, so I'll set this bug to ITM 15, sync up with 5.10 backport ITM. Same as other xdp-tools bugs. otherwise, it will pass the Beta. it may need you to fix them at least by ITM 13or14, is that OK for you? Sure, that should be fine :) Scratch build what should fix this available here: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=34045153 Will turn it into a proper build as soon as I figure out how to get a new branch created in dist-git... This issue won't be reproduced in the new version [root@netqe30 ~]# rpm -q xdp-tools xdp-tools-1.1.0-1.el8.x86_64 [root@netqe30 ~]# uname -r 4.18.0-277.el8.x86_64 [root@netqe30 ~]# rpm -q libxdp libxdp-1.1.0-1.el8.x86_64 [root@netqe30 ~]# rpm -q libbpf libbpf-0.0.8-4.el8.x86_64 [root@netqe30 ~]# [root@netqe30 ~]# ethtool -i ens3np0 driver: nfp version: 4.18.0-277.el8.x86_64 firmware-version: 0.0.3.5 0.22 bpf-2.0.6.124 ebpf expansion-rom-version: bus-info: 0000:5e:00.0 supports-statistics: yes supports-test: no supports-eeprom-access: no supports-register-dump: yes supports-priv-flags: no [root@netqe30 ~]# xdp-loader load ens3np0 xdp_prog_kern.o [root@netqe30 ~]# xdp-loader status CURRENT XDP PROGRAM STATUS: Interface Prio Program name Mode ID Tag Chain actions ------------------------------------------------------------------------------------- lo <no XDP program> eno1 <no XDP program> ens1f0 <no XDP program> eno2 <no XDP program> ens1f1 <no XDP program> eno3 <no XDP program> eno4 <no XDP program> ens2f0 <no XDP program> ens2f1 <no XDP program> ens3np0 xdp_dispatcher native 81 d51e469e988d81da => 50 xdp_pass_func 93 3b185187f1855c4c XDP_PASS ens3np1 <no XDP program> [root@netqe30 ~]# xdp-loader unload ens3np0 -a [root@netqe30 ~]# xdp-loader status CURRENT XDP PROGRAM STATUS: Interface Prio Program name Mode ID Tag Chain actions ------------------------------------------------------------------------------------- lo <no XDP program> eno1 <no XDP program> ens1f0 <no XDP program> eno2 <no XDP program> ens1f1 <no XDP program> eno3 <no XDP program> eno4 <no XDP program> ens2f0 <no XDP program> ens2f1 <no XDP program> ens3np0 <no XDP program> ens3np1 <no XDP program> base on Comment15, set this to VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (xdp-tools bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:1925 |