Bug 188097 - Glslideshow crashes xscreensaver-demo
Summary: Glslideshow crashes xscreensaver-demo
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: xscreensaver
Version: 4
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ray Strode [halfline]
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-04-06 00:29 UTC by Scott R. Godin
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-01-22 21:59:13 UTC


Attachments (Terms of Use)
backtrace and two core files (1.15 MB, application/x-gzip)
2006-04-06 00:29 UTC, Scott R. Godin
no flags Details
Patch to prevent double free in demo-Gtk.c (380 bytes, patch)
2006-05-11 11:54 UTC, Mamoru TASAKA
no flags Details | Diff

Description Scott R. Godin 2006-04-06 00:29:43 UTC
Description of problem:
Glslideshow crashes xscreensaver-demo if 'preview' is done more than 2-3 times

Version-Release number of selected component (if applicable):
4.21-4

How reproducible:
every time


Steps to Reproduce:
1. run xscreensaver-demo and select GLSlideshow from the list
2. wait for the preview in the mini-window to appear, and press the Preview 
button. 
3. click on the screen to cancel the preview. lather, rinse, repeat, 2-3 times, 
and xscreensaver-demo will dump core
  
Actual results:
core dump

Expected results:
continued preview of random images

Additional info:

I have two core files, and a gdb backtrace of one of them I will attach

Comment 1 Scott R. Godin 2006-04-06 00:29:44 UTC
Created attachment 127382 [details]
backtrace and two core files

Comment 2 Mamoru TASAKA 2006-05-11 11:54:11 UTC
Created attachment 128879 [details]
Patch to prevent double free in demo-Gtk.c

I don't have FC4 system any more and so I cannot make use of core file.
But by checking xscreensaver-backtrace.txt in the attachment in the
comment 1, it is found that this is a problem of double-free in run_hack()
in demo-Gtk.c

A patch is attached to fix this problem.
Note: this problem is already fixed in version 4.24.

Comment 3 Christian Iseli 2007-01-22 11:59:25 UTC
This report targets the FC3 or FC4 products, which have now been EOL'd.

Could you please check that it still applies to a current Fedora release, and
either update the target product or close it ?

Thanks.

Comment 4 Scott R. Godin 2007-01-22 21:59:13 UTC
fixed as of FC5. sorry I didn't get back to this to test it. thanks for the 
reminder. 

even if I point it at ~/Pictures now, which has some huge files in it, there 
are no coredumps.


Note You need to log in before you can comment on or make changes to this bug.